Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Django 4 #447

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Support Django 4 #447

merged 3 commits into from
Mar 7, 2022

Conversation

dyve
Copy link
Member

@dyve dyve commented Mar 7, 2022

Fixes: #398

@dyve dyve marked this pull request as ready for review March 7, 2022 07:34
@dyve dyve requested a review from jieter March 7, 2022 07:34
jieter
jieter approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@jieter jieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is fixed in django-bootstrap5, it would be nice to have a link to the commit implementing it over there.

This patch looks good in itself, I'd be ok merging it like this.

tests/utils.py Outdated
@@ -3,7 +3,7 @@

from .forms import TestForm

DJANGO3 = get_version() >= "3"
DJANGO_VERSION = int(get_version()[:1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the package's DJANGO_VERSION?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that, good catch.

@dyve
Copy link
Member Author

dyve commented Mar 7, 2022

Django 4 support in django-bootstrap5 works differently because the renderers were rewritten for that package. Here's the link:
zostera/django-bootstrap5#193

@dyve dyve merged commit 7ee7b1b into main Mar 7, 2022
@dyve dyve deleted the feature/django4 branch March 7, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieter jieter jieter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 4 support
2 participants
@dyve @jieter