Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two params made mandatory, changed max length for others #11

Merged
merged 1 commit into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![NPM version](https://img.shields.io/badge/zotasdk-v1.1.0-blue)](https://www.npmjs.com/package/zotapaysdk)
[![NPM version](https://img.shields.io/badge/zotasdk-v1.1.1-blue)](https://www.npmjs.com/package/zotapaysdk)
[![codecov](https://codecov.io/gh/zotapay/node-sdk/branch/main/graph/badge.svg?token=NdEjuAL8eN)](https://codecov.io/gh/zotapay/node-sdk)
![](https://img.shields.io/badge/NodeJS-14%2B-blue)
![unnamed](https://user-images.githubusercontent.com/92689934/184654665-59808ddc-ed33-4347-b274-0e0c94368ce9.png)
Expand Down
22 changes: 11 additions & 11 deletions zotapaysdk/mg_requests/deposit_request.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class MGDepositRequest extends DepositRequestParameters {
this._orderAmount = new MGRequestParam(
DepositRequestParameters.ORDER_AMOUNT,
orderAmount,
12,
24,
true
)

Expand All @@ -58,21 +58,21 @@ class MGDepositRequest extends DepositRequestParameters {
this._customerFirstName = new MGRequestParam(
DepositRequestParameters.CUSTOMER_FIRST_NAME,
customerFirstName,
50,
128,
true
)

this._customerLastName = new MGRequestParam(
DepositRequestParameters.CUSTOMER_LAST_NAME,
customerLastName,
50,
128,
true
)

this._customerAddress = new MGRequestParam(
DepositRequestParameters.CUSTOMER_ADDRESS,
customerAddress,
50,
128,
true
)

Expand All @@ -86,7 +86,7 @@ class MGDepositRequest extends DepositRequestParameters {
this._customerCity = new MGRequestParam(
DepositRequestParameters.CUSTOMER_CITY,
customerCity,
50,
128,
true
)

Expand All @@ -100,7 +100,7 @@ class MGDepositRequest extends DepositRequestParameters {
this._customerZipCode = new MGRequestParam(
DepositRequestParameters.CUSTOMER_ZIP_CODE,
customerZipCode,
10,
15,
true
)

Expand All @@ -114,35 +114,35 @@ class MGDepositRequest extends DepositRequestParameters {
this._customerIP = new MGRequestParam(
DepositRequestParameters.CUSTOMER_IP,
customerIP,
20,
64,
true
)

this._customerBankCode = new MGRequestParam(
DepositRequestParameters.CUSTOMER_BANK_CODE,
customerBankCode,
8,
11,
false
)

this._redirectUrl = new MGRequestParam(
DepositRequestParameters.REDIRECT_URL,
redirectUrl,
128,
255,
true
)

this._callbackUrl = new MGRequestParam(
DepositRequestParameters.CALLBACK_URL,
callbackUrl,
128,
255,
false
)

this._checkoutUrl = new MGRequestParam(
DepositRequestParameters.CHECKOUT_URL,
checkoutUrl,
128,
255,
true
)

Expand Down
20 changes: 10 additions & 10 deletions zotapaysdk/mg_requests/payout_request.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class MGPayoutRequest extends PayoutRequestParameters {
this._orderAmount = new MGRequestParam(
PayoutRequestParameters.ORDER_AMOUNT,
orderAmount,
12,
24,
true
)

Expand All @@ -51,20 +51,20 @@ class MGPayoutRequest extends PayoutRequestParameters {
PayoutRequestParameters.CUSTOMER_EMAIL,
customerEmail,
50,
false
true
)

this._customerFirstName = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_FIRST_NAME,
customerFirstName,
50,
128,
true
)

this._customerLastName = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_LAST_NAME,
customerLastName,
50,
128,
true
)

Expand All @@ -78,21 +78,21 @@ class MGPayoutRequest extends PayoutRequestParameters {
this._customerIP = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_IP,
customerIP,
20,
64,
true
)

this._customerBankCode = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_BANK_CODE,
customerBankCode,
8,
11,
false
)

this._customerBankAccountNumber = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_BANK_ACCOUNT_NUMBER,
customerBankAccountNumber,
15,
64,
true
)
this._customerBankAccountName = new MGRequestParam(
Expand Down Expand Up @@ -122,7 +122,7 @@ class MGPayoutRequest extends PayoutRequestParameters {
this._customerBankRoutingNumber = new MGRequestParam(
PayoutRequestParameters.CUSTOMER_BANK_ROUTING_NUMBER,
customerBankRoutingNumber,
16,
64,
false
)
this._customerBankProvince = new MGRequestParam(
Expand All @@ -141,7 +141,7 @@ class MGPayoutRequest extends PayoutRequestParameters {
this._callbackUrl = new MGRequestParam(
PayoutRequestParameters.CALLBACK_URL,
callbackUrl,
128,
255,
false
)

Expand All @@ -156,7 +156,7 @@ class MGPayoutRequest extends PayoutRequestParameters {
PayoutRequestParameters.CUSTOMER_COUNTRY_CODE,
customerCountryCode,
2,
false
true
)

this._customerPersonalID = new MGRequestParam(
Expand Down