New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create National Library of Norway.js #1059

Merged
merged 1 commit into from May 20, 2016

Conversation

Projects
None yet
3 participants
@danmichaelo
Contributor

danmichaelo commented May 8, 2016

I’m relying mostly on the RIS translator.

To detect the document type without having to fetch the RIS file, I'm using an input field part of a feedback form (//input[@id="mediaType"]). This works, but seems a bit fragile, so I will try to get in contact with the library about a better solution. The best would be to have something like RDFa markup I guess.

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith May 19, 2016

Collaborator

some nits inline, looks nice otherwise. Thanks!

Collaborator

adam3smith commented May 19, 2016

some nits inline, looks nice otherwise. Thanks!

@adam3smith adam3smith merged commit f15c4d1 into zotero:master May 20, 2016

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith May 20, 2016

Collaborator

thanks!

Collaborator

adam3smith commented May 20, 2016

thanks!

@danmichaelo danmichaelo deleted the danmichaelo:nb branch Nov 29, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment