Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the annotation bar movable/dockable #101

Open
dstillman opened this issue Dec 27, 2023 · 1 comment
Open

Make the annotation bar movable/dockable #101

dstillman opened this issue Dec 27, 2023 · 1 comment
Labels
Enhancement

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/110404/android-place-of-annotation-bar

4 positions, as in the iOS app
Dima-Android added a commit that referenced this issue Jan 23, 2024
@Dima-Android
First implementation stab at “Make the annotation bar movable/dockable …
2db483b 
…#101”

Start of refactoring of build.gradle’s dependencies. Moving them into “Libs.kt” and several Plugin classes. This not only groups related dependencies and makes updating several dependencies with the same version number easier, but also will allow us to configure CI to use a dependency cache and point mentioned classes to the CI to use them as a hash to decide when to update the cache, which should speed up the build process.

Upping versionCode to 42
@Dima-Android
Copy link
Collaborator

I’ve discovered that Google just recently released an update to compose where it’s added a special API for implementing dragging views across the screen. It looked like exactly what we need.
I’ve implemented the ability to change the position of the sidebar just from left to right. For now it cannot be dragged to the top. As it turns out the way you use this API is by telling it which direction the view is gonna be dragged and it only has two values - vertical and horizontal. I’ve looked into the source code of the API itself to figure out how to make it to allow the view to be moved in all directions but it seems impossible.
So for now we will only have the toolbar drag-snap to the left and right. Actually as I’ve been implementing this feature I’ve realized that it’s totally possible to implement desired dragging behavior in any direction, but with the help of much lower-level gesture API. It will take more effort to code it up, but with how much I’ve learned by now it shouldn’t take much time.
So let’s call the current implementation a first stab. I will improve upon it later.

Dima-Android added a commit that referenced this issue Jan 25, 2024
@Dima-Android
First implementation stab at “Make the annotation bar movable/dockable …
8264657 
…#101”

Start of refactoring of build.gradle’s dependencies. Moving them into “Libs.kt” and several Plugin classes. This not only groups related dependencies and makes updating several dependencies with the same version number easier, but also will allow us to configure CI to use a dependency cache and point mentioned classes to the CI to use them as a hash to decide when to update the cache, which should speed up the build process.
Upping veersion code to 43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstillman @Dima-Android