Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML tree: Find as you type should apply to all trees #2169

Closed
dstillman opened this issue Aug 29, 2021 · 0 comments · Fixed by #2176
Closed

HTML tree: Find as you type should apply to all trees #2169

dstillman opened this issue Aug 29, 2021 · 0 comments · Fixed by #2176
Assignees
@adomasven
Labels
Regression

Comments

@dstillman
Copy link
Member

FAYT should be a feature of the tree itself, not of the collection and item trees specifically
@dstillman dstillman mentioned this issue Aug 29, 2021
Closed
@adomasven adomasven mentioned this issue Aug 30, 2021
Closed
adomasven added a commit to adomasven/zotero that referenced this issue Aug 30, 2021
@adomasven
HTML Tree: make find as you type a virtualized table functionality
2779bfa 
Closes zotero#2168, closes zotero#2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
adomasven added a commit to adomasven/zotero that referenced this issue Aug 30, 2021
@adomasven
HTML Tree: make find as you type a virtualized table functionality
1b82e7e 
Closes zotero#2168, closes zotero#2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
@adomasven adomasven mentioned this issue Aug 30, 2021
Merged
adomasven added a commit to adomasven/zotero that referenced this issue Aug 30, 2021
@adomasven
HTML Tree: make find as you type a virtualized table functionality
21505e8 
Closes zotero#2168, closes zotero#2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
dstillman pushed a commit that referenced this issue Aug 30, 2021
@adomasven
HTML Tree: make find as you type a virtualized table functionality (#…
cb9df90 
…2176)

Closes #2168, closes #2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adomasven adomasven

Labels
Regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HTML Tree: make find as you type a virtualized table functionality adomasven/zotero
2 participants
@dstillman @adomasven