Feature/docker whitelist #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker images supported can be limited by whitelist, and docker commands disabled
|
@wyvern8 Looks good, but do we maybe want to externalise the whitelist config in a future change, as I can imagine a few situations where the whitelist might include potentially hundreds of items and it might get a bit cumbersome if we store it in env. Since the agent is a deployed thing and will (usually) have a mapped disk could we add a config file for allowed ones? |
whitelist entries are now treated as regex, and an optional GTM_DOCKER_IMAGE_WHITELIST_FILE can be used for larger lists.
|
@Neko-Design - true - whitelist file is a good idea for larger sets, so added this as GTM_DOCKER_IMAGE_WHITELIST_FILE to point at an approot relative file. also, each entry from either location is now treated as a regex so do not need to version lock ie. can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an env var GTM_DOCKER_IMAGE_WHITELIST is set, the docker executor will only pull and run images listed in this comma separated list.
if a command option is passed to the docker executor, it will only be run if :
GTM_DOCKER_COMMANDS_ALLOWED=true
also adding support for task options to passs env vars into docker containers using the task.options.env array. note format apocas/dockerode#130