add test, eslint

Author: zoubin

.eslintrc

@@ -0,0 +1,84 @@
+---
+ecmaFeatures:
+  modules: true
+
+env:
+  browser: true
+  node: true
+  es6: true
+
+rules:
+  comma-dangle: [2, "always-multiline"]
+  no-dupe-args: 2
+  no-dupe-keys: 2
+  no-duplicate-case: 2
+  no-empty-character-class: 2
+  no-ex-assign: 1
+  no-extra-boolean-cast: 1
+  no-extra-parens: 1
+  no-extra-semi: 1
+  no-func-assign: 1
+  no-inner-declarations: 1
+  no-invalid-regexp: 1
+  no-irregular-whitespace: 1
+  no-negated-in-lhs: 1
+  no-obj-calls: 1
+  no-regex-spaces: 1
+  no-sparse-arrays: 1
+  no-unreachable: 1
+  use-isnan: 1
+  valid-typeof: 2
+  no-unexpected-multiline: 1
+  no-cond-assign: 1
+  no-constant-condition: 1
+  no-control-regex: 1
+  no-debugger: 1
+  # code style
+  consistent-return: 1
+  curly: 1
+  default-case: 1
+  dot-notation: 1
+  dot-location: [1, "property"]
+  eqeqeq: 1
+  no-else-return: 1
+  no-lone-blocks: 1
+  no-loop-func: 1
+  no-multi-spaces: 1
+  no-multi-str: 1
+  no-proto: 1
+  no-redeclare: 1
+  no-return-assign: 1
+  no-sequences: 1
+  no-throw-literal: 1
+  no-unused-expressions: 1
+  no-void: 1
+  no-warning-comments: [1, { "terms": ["todo", "fixme", "xxx"], "location": "start"  }]
+  no-with: 1
+  radix: 1
+  wrap-iife: [2, "inside"]
+  no-delete-var: 1
+  no-shadow-restricted-names: 1
+  no-shadow: 1
+  no-undef: 2
+  no-unused-vars: 1
+  brace-style: [1, "1tbs", { "allowSingleLine": true }]
+  comma-spacing: 1
+  comma-style: 1
+  consistent-this: [2, "self"]
+  indent: [2, 2]
+  key-spacing: 1
+  max-nested-callbacks: [2, 3]
+  no-lonely-if: 2
+  no-mixed-spaces-and-tabs: 2
+  no-nested-ternary: 2
+  no-spaced-func: 2
+  no-trailing-spaces: 2
+  one-var: [2, "never"]
+  operator-linebreak: 2
+  quote-props: [2, "as-needed"]
+  quotes: [2, "single", "avoid-escape"]
+  semi: [2, "always"]
+  space-after-keywords: 2
+  space-before-blocks: 2
+  space-infix-ops: 2
+  space-return-throw-case: 2

.gitignore

@@ -1 +1,3 @@
 /node_modules/
+.DS_Store
+npm-debug.log

.npmignore

@@ -1,3 +1,4 @@
 .gitignore
 /test/
 /example/
+npm-debug.log

index.js

@@ -2,30 +2,30 @@ var util = require('util');
 var runTask = require('orchestrator/lib/runTask');
 
 module.exports = function (callbacks) {
-    if (!callbacks) {
-        callbacks = [];
-    }
-    if (!Array.isArray(callbacks)) {
-        callbacks = Array.prototype.slice.call(arguments);
-    }
-    callbacks = callbacks.filter(util.isFunction);
+  if (!callbacks) {
+    callbacks = [];
+  }
+  if (!Array.isArray(callbacks)) {
+    callbacks = Array.prototype.slice.call(arguments);
+  }
+  callbacks = callbacks.filter(util.isFunction);
 
-    var maxLen = callbacks.length;
+  var maxLen = callbacks.length;
 
-    return function (done) {
-        done = done || function () {};
+  return function (done) {
+    done = done || function () {};
 
-        (function next(i) {
-            if (i >= maxLen) {
-                return done();
-            }
-            var cb = callbacks[i];
-            runTask(cb, function (err) {
-                if (err) {
-                    return done(err);
-                }
-                next(++i);
-            });
-        }(0));
-    };
+    (function next(i) {
+      if (i >= maxLen) {
+        return done();
+      }
+      var cb = callbacks[i];
+      runTask(cb, function (err) {
+        if (err) {
+          return done(err);
+        }
+        next(++i);
+      });
+    })(0);
+  };
 };

package.json

@@ -4,7 +4,7 @@
   "description": "Make a new callback to run input callbacks in sequence",
   "main": "index.js",
   "scripts": {
-    "test": "tap test/*.js"
+    "test": "eslint . && tap test/*.js"
   },
   "repository": {
     "type": "git",
@@ -27,6 +27,7 @@
     "orchestrator": "^0.3.7"
   },
   "devDependencies": {
+    "eslint": "^1.1.0",
     "tap": "^1.3.1"
   }
 }

test/async.js

@@ -0,0 +1,24 @@
+var test = require('tape');
+var sequence = require('..');
+
+test('async', function(t) {
+  t.plan(4);
+  var i = 0;
+  sequence(
+    next(0),
+    next(1),
+    next(2)
+  )(function () {
+    t.ok(true);
+  });
+
+  function next(j) {
+    return function (done) {
+      process.nextTick(function () {
+        t.equal(i++, j);
+        done();
+      });
+    };
+  }
+});
+

test/index.js

@@ -0,0 +1,36 @@
+var test = require('tape');
+var sequence = require('..');
+var Readable = require('stream').Readable;
+
+test('mixed', function(t) {
+  t.plan(5);
+  var i = 0;
+  sequence(
+    function () {
+      t.equal(i++, 0);
+    },
+    function (done) {
+      process.nextTick(function () {
+        t.equal(i++, 1);
+        done();
+      });
+    },
+    function () {
+      return new Promise(function (resolve) {
+        t.equal(i++, 2);
+        resolve();
+      });
+    },
+    function () {
+      var s = Readable();
+      process.nextTick(function () {
+        t.equal(i++, 3);
+        s.push(null);
+      });
+      return s;
+    }
+  )(function () {
+    t.ok(true);
+  });
+});
+

test/mixed.js

@@ -0,0 +1,24 @@
+var test = require('tape');
+var sequence = require('..');
+
+test('promise', function(t) {
+  t.plan(4);
+  var i = 0;
+  sequence(
+    next(0),
+    next(1),
+    next(2)
+  )(function () {
+    t.ok(true);
+  });
+
+  function next(j) {
+    return function () {
+      return new Promise(function (resolve) {
+        t.equal(i++, j);
+        resolve();
+      });
+    };
+  }
+});
+

test/promise.js

@@ -0,0 +1,47 @@
+var test = require('tape');
+var sequence = require('..');
+var Readable = require('stream').Readable;
+
+test('recursive', function(t) {
+  t.plan(5);
+  var i = 0;
+  var sync = function () {
+    t.equal(i++, 0);
+  };
+  var async = function (done) {
+    process.nextTick(function () {
+      t.equal(i++, 1);
+      done();
+    });
+  };
+  var stream = function () {
+    var s = Readable();
+    process.nextTick(function () {
+      t.equal(i++, 3);
+      s.push(null);
+    });
+    return s;
+  };
+  var promise = function () {
+    return new Promise(function (resolve) {
+      t.equal(i++, 2);
+      resolve();
+    });
+  };
+
+  sequence(
+    sync,
+    sequence(
+      async,
+      sequence(
+        promise,
+        sequence(
+          stream
+        )
+      )
+    )
+  )(function () {
+    t.ok(true);
+  });
+});
+