Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier - get formatting happen on pre-commit hook #40

Closed
zouhir opened this issue Jan 14, 2018 · 2 comments
Closed

Add prettier - get formatting happen on pre-commit hook #40

zouhir opened this issue Jan 14, 2018 · 2 comments

Comments

@zouhir
Copy link
Owner

zouhir commented Jan 14, 2018

Prettier, husky and lint-staged would be a great addition to this repo to format the code when the user make a commit.

Ideally, everything inside src should be formatted.

Read more about:

@Sunshine168
Copy link
Contributor

in firstly, confirming the coding style for this repo , and then we can add eslint and eslint check or prettier-eslint to format the code in pre-commit

@zouhir
Copy link
Owner Author

zouhir commented Jan 15, 2018

I think just vanilla prettier, prettier-eslint is not really important to me. default prettier settings would be great!

@lukeed lukeed mentioned this issue Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants