Fixes #97: Correctly calculate download times #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic!!!!!! 😻 I'll pull this tomorrow morning, try and then merge.. looks great tho! Thank you! |
lukeed
approved these changes
Jan 31, 2018
|
hmmm I think we have a problem here, the calculations are bit more far off still on my end after pulling your branch :(
|
|
Yep, looks like we're getting the asset size in bytes, not kB. Thanks for testing that! 👍 Fixed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #97 for an exact description of the problem. Changed the formula used to calculate download times to fix unit conversions.
Additionally moved the calculation results out of the state, instead calculating them while rendering. Results are memoized to avoid duplicate calculations.