Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local CA signed certificate for discoverable-client on localhost #170

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

plavjanik
Copy link
Contributor

@plavjanik plavjanik commented Jan 3, 2019

Uses the original keystore keystore/localhost/localhost.keystore.p12 for discoverable-client instead of a self-signed certificate.

The reason is to make it easier to create new local CA and truststore for the APIML without additional steps to trust the self-signed certificate.

Signed-off-by: Petr Plavjanik <petr.plavjanik@broadcom.com>
@ghost ghost assigned plavjanik Jan 3, 2019
@ghost ghost added the review label Jan 3, 2019
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, make sense :-)

@JirkaAichler
Copy link
Contributor

Jenkins doesn't seem to be building :-(

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage     57.91%   57.91%           
  Complexity       29       29           
=========================================
  Files           178      178           
  Lines          3495     3495           
  Branches        476      476           
=========================================
  Hits           2024     2024           
  Misses         1338     1338           
  Partials        133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08e198...13ed9fd. Read the comment docs.

@plavjanik plavjanik merged commit ac70aca into master Jan 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the no-selfsigned-in-dc branch January 4, 2019 15:51
@ghost ghost removed the review label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants