fix: allow key exchange port configuration #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: achmelo <a.chmelo@gmail.com>
pablocarle
reviewed
Mar 8, 2024
...service/src/main/java/org/zowe/apiml/caching/service/infinispan/config/InfinispanConfig.java
Outdated
Show resolved
Hide resolved
pablocarle
approved these changes
Mar 8, 2024
Signed-off-by: achmelo <a.chmelo@gmail.com>
Signed-off-by: achmelo <a.chmelo@gmail.com>
|
|
Does this property need to be added to the schema for zowe.yaml? |
We need to add many configuration parameters in the caching-schema.json so I would propose to have a separate issue/PR to address this. |
achmelo
added a commit
that referenced
this pull request
Apr 23, 2024
* allow key exchange port configuration Signed-off-by: achmelo <a.chmelo@gmail.com> * explain different defaults for the port Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same default port number Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit d82322e)
achmelo
added a commit
that referenced
this pull request
Apr 24, 2024
* fix: allow key exchange port configuration (#3453) * allow key exchange port configuration Signed-off-by: achmelo <a.chmelo@gmail.com> * explain different defaults for the port Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same default port number Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit d82322e) * chore: Change log levels for WS and Identity Mapper and add service info (#3344) * add info about the southbound service request for authsource Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add debug msg for websocket routing Signed-off-by: at670475 <andrea.tabone@broadcom.com> * address pr comments Signed-off-by: at670475 <andrea.tabone@broadcom.com> --------- Signed-off-by: at670475 <andrea.tabone@broadcom.com> (cherry picked from commit 0a888f8) * fix: Respect configuration enabling JWT Token Refresh Functionality #3468 (#3474) * Respect JWT Refresh Configuration from zowe.yaml Signed-off-by: Jakub Balhar <jakub@balhar.net> * Fix the default in shell. Signed-off-by: Jakub Balhar <jakub@balhar.net> --------- Signed-off-by: Jakub Balhar <jakub@balhar.net> (cherry picked from commit b4146be) * feat: include OIDC JWKSet in the gateway JWKs (#3499) * use the same JWK format, include OIDC keys in the response Signed-off-by: achmelo <a.chmelo@gmail.com> * cleanup, update tests Signed-off-by: achmelo <a.chmelo@gmail.com> * integration test for local validation Signed-off-by: achmelo <a.chmelo@gmail.com> * set default ssl factory Signed-off-by: achmelo <a.chmelo@gmail.com> * change debug message Signed-off-by: achmelo <a.chmelo@gmail.com> * test coverage Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit a588a8f) Signed-off-by: achmelo <a.chmelo@gmail.com> * feat: forward valid OIDC token to southbound service in case of distributed ID is not mapped (#3497) * forward token and message in case of missing mapping Signed-off-by: at670475 <andrea.tabone@broadcom.com> * fix test Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add unit test Signed-off-by: at670475 <andrea.tabone@broadcom.com> * small refactoring Signed-off-by: at670475 <andrea.tabone@broadcom.com> * updating integration tests Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add test Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add exception to the error handler to return correct response code Signed-off-by: at670475 <andrea.tabone@broadcom.com> * fix styles Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: at670475 <andrea.tabone@broadcom.com> Signed-off-by: achmelo <a.chmelo@gmail.com> Co-authored-by: achmelo <37397715+achmelo@users.noreply.github.com> Co-authored-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit 60777c1) * fix: check for nullpointer exception when jwk key can't be retrieved (#3503) * check for nullpointer ex when jwk key can't be retrieved Signed-off-by: at670475 <andrea.tabone@broadcom.com> * add test Signed-off-by: at670475 <andrea.tabone@broadcom.com> * address comment Signed-off-by: at670475 <andrea.tabone@broadcom.com> --------- Signed-off-by: at670475 <andrea.tabone@broadcom.com> (cherry picked from commit 7c00dba) * revert Signed-off-by: achmelo <a.chmelo@gmail.com> * use current methods Signed-off-by: achmelo <a.chmelo@gmail.com> * feat: Move OIDC access token from cookie to special header (#3513) * POC Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * fix Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * replace old constructors Signed-off-by: achmelo <a.chmelo@gmail.com> * update IT Signed-off-by: achmelo <a.chmelo@gmail.com> * fix Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * update IT Signed-off-by: achmelo <a.chmelo@gmail.com> * fix IT Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * exception handler for no MF ID, unit test Signed-off-by: achmelo <a.chmelo@gmail.com> * unit tests for request modification Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * license Signed-off-by: achmelo <a.chmelo@gmail.com> * minor changes Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * lowercase header Signed-off-by: achmelo <a.chmelo@gmail.com> * remove import Signed-off-by: achmelo <a.chmelo@gmail.com> * remove authorization header from httpservletrequest Signed-off-by: achmelo <a.chmelo@gmail.com> * test no ID and invalid token Signed-off-by: achmelo <a.chmelo@gmail.com> * ignore cookies if auth cookie only remains Signed-off-by: achmelo <a.chmelo@gmail.com> * expect no cookie in request Signed-off-by: achmelo <a.chmelo@gmail.com> * fix sonar Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> --------- Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> Signed-off-by: achmelo <a.chmelo@gmail.com> Co-authored-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit 6248308) * url without default Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same jwk uri Signed-off-by: achmelo <a.chmelo@gmail.com> * attempt to fix IT Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> * Revert "attempt to fix IT" This reverts commit cf35400. * use keyLocator for JWK set Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> Signed-off-by: Pavel Jares <Pavel.Jares@broadcom.com> Co-authored-by: Andrea Tabone <39694626+taban03@users.noreply.github.com> Co-authored-by: Jakub Balhar <jakub@balhar.net> Co-authored-by: Pavel Jareš <58428711+pj892031@users.noreply.github.com> Co-authored-by: Pavel Jares <Pavel.Jares@broadcom.com>
achmelo
added a commit
that referenced
this pull request
May 27, 2024
* fix: allow key exchange port configuration (#3453) * allow key exchange port configuration Signed-off-by: achmelo <a.chmelo@gmail.com> * explain different defaults for the port Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same default port number Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit d82322e) * configure external protocol from zowe yaml Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com>
pj892031
pushed a commit
that referenced
this pull request
May 27, 2024
* fix: allow key exchange port configuration (#3453) * allow key exchange port configuration Signed-off-by: achmelo <a.chmelo@gmail.com> * explain different defaults for the port Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same default port number Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit d82322e) * configure external protocol from zowe yaml Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com>
achmelo
added a commit
that referenced
this pull request
Jun 10, 2024
* fix: allow key exchange port configuration (#3453) * allow key exchange port configuration Signed-off-by: achmelo <a.chmelo@gmail.com> * explain different defaults for the port Signed-off-by: achmelo <a.chmelo@gmail.com> * use the same default port number Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com> (cherry picked from commit d82322e) * convert App to function Signed-off-by: achmelo <a.chmelo@gmail.com> --------- Signed-off-by: achmelo <a.chmelo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to configure Infinispan SSL key exchange port from external configuration, e.g. zowe.yaml.
Linked to #3450
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline