Improve usability of authentication client #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
============================================
+ Coverage 66.69% 70.04% +3.34%
Complexity 12 12
============================================
Files 216 234 +18
Lines 4138 4353 +215
Branches 547 560 +13
============================================
+ Hits 2760 3049 +289
+ Misses 1239 1159 -80
- Partials 139 145 +6
Continue to review full report at Codecov.
|
IgorCATech
reviewed
Aug 9, 2019
apiml-common/src/main/java/com/ca/mfaas/product/gateway/GatewayClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: janda06 <david.janda@broadcom.com>
changed catalog to use the lookup service various fixes for catalog startup aligned componentscan to common place for gw Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
- Deleted gateway login url - Removed @EnableConfigurationProperties from main classes - Removed @configuration from main classes - Some refactoring - Unit tests disabled temporary
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
ilkinabdullayev
force-pushed
the
janda06/SSCGatewayConfigRework
branch
from
739f17f
to
d1d9ab7
Compare
Signed-off-by: janda06 <david.janda@broadcom.com>
JirkaAichler
approved these changes
Aug 14, 2019
IgorCATech
reviewed
Aug 14, 2019
| @@ -104,7 +106,7 @@ private void processInstance(Applications filteredServices, Application applicat | |||
| String value = instanceInfo.getMetadata().get(API_ENABLED_METADATA_KEY); | |||
| boolean apiEnabled = true; | |||
| if (value != null) { | |||
| apiEnabled = Boolean.valueOf(value); | |||
| apiEnabled = Boolean.parseBoolean(value); | |||
| } | |||
|
|
|||
| // only add api enabled services | |||
There was a problem hiding this comment.
Only add? or add only API enabled services?
IgorCATech
reviewed
Aug 14, 2019
| @@ -42,11 +45,17 @@ | |||
|
|
|||
| /** | |||
| * Periodically refresh the container/service caches | |||
| * Depends on the GatewayClient: no refreshes happen when it's not initialized | |||
There was a problem hiding this comment.
I'd rather explain what will happen if "it's initiated". For example "The GatewayClient initialization refreshes the container/service cache"
IgorCATech
reviewed
Aug 14, 2019
| @@ -149,16 +158,16 @@ private void processServiceInstance(Set<String> containersUpdated, Applications | |||
| } | |||
|
|
|||
| /** | |||
| * Go ahead amd retrieve this instances API doc and update the cache | |||
| * Go ahead and retrieve this instances API doc and update the cache | |||
There was a problem hiding this comment.
This doesn't make much sense grammatically.
"Ensure that you retrieve the API doc of this instance, and update the cache". Also we need to make sure it's understood what instance we refer to here. What is "This instance"?
IgorCATech
reviewed
Aug 14, 2019
| import java.net.URI; | ||
|
|
||
| /** | ||
| * GatewayInstanceInitializer takes care about starting the lookup for Gateway instance after the context is started |
There was a problem hiding this comment.
"GatewayInstanceInitializer starts the lookup for Gateway instance after the context is started"
"takes care" is too vague
IgorCATech
reviewed
Aug 14, 2019
|
|
||
| /** | ||
| * GatewayInstanceInitializer takes care about starting the lookup for Gateway instance after the context is started | ||
| * Its meant to be created as a bean, as it is for example by SecurityServiceConfiguration in security-service-client-spring |
There was a problem hiding this comment.
I'd rewrite this - has grammatical mistakes and is generally hard to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy Reviews!