Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Catalog version in footer for Login, Dasboard and Detail pages #3554

Merged
merged 2 commits into from
May 27, 2024

Conversation

boris-bc
Copy link
Contributor

@boris-bc boris-bc commented May 22, 2024

Description

This change adds version number to the Login, Dashboard and Detail pages. The version number is taken from the gradle.properties and is populated into .env, from where it is displayed in the pages. The changes also contain a little bit of code cleanup removing some of the API portal specific code that is no longer used from this repo.

image image image

Linked to #3332

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

@boris-bc boris-bc force-pushed the boris-bc/catalog-version-in-footer branch from 45703e4 to a4059a2 Compare May 22, 2024 13:07
@boris-bc boris-bc force-pushed the boris-bc/catalog-version-in-footer branch 2 times, most recently from 103d9a7 to afa8434 Compare May 22, 2024 13:26
@taban03
Copy link
Contributor

taban03 commented May 22, 2024

maybe we can have an e2e (cypress) test to check that the label is visible

@boris-bc boris-bc force-pushed the boris-bc/catalog-version-in-footer branch from afa8434 to 9d42acd Compare May 22, 2024 13:36
@boris-bc
Copy link
Contributor Author

maybe we can have an e2e (cypress) test to check that the label is visible

Tests added.

Signed-off-by: Boris Petkov <boris.petkov@broadcom.com>
@boris-bc boris-bc force-pushed the boris-bc/catalog-version-in-footer branch from 9d42acd to bf2a5f9 Compare May 22, 2024 13:49
@taban03 taban03 changed the title Catalog version in footer for Login, Dasboard and Detail pages feat: Catalog version in footer for Login, Dasboard and Detail pages May 22, 2024
Copy link

sonarcloud bot commented May 27, 2024

@balhar-jakub
Copy link
Member

This looks really good. Thanks for the change.

@balhar-jakub balhar-jakub merged commit fd75d1b into v3.x.x May 27, 2024
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the boris-bc/catalog-version-in-footer branch May 27, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants