Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery service authentication #358

Merged
merged 22 commits into from
Sep 4, 2019
Merged

Discovery service authentication #358

merged 22 commits into from
Sep 4, 2019

Conversation

jandadav
Copy link
Contributor

Change of Discovery service security to protect endpoints with MF credentials or apiml token

@jandadav jandadav changed the title Janda06/eureka auth Discovery service authentication Aug 26, 2019
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #358 into master will decrease coverage by 0.15%.
The diff coverage is 40.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
- Coverage     70.04%   69.88%   -0.16%     
  Complexity       12       12              
============================================
  Files           234      236       +2     
  Lines          4353     4393      +40     
  Branches        560      559       -1     
============================================
+ Hits           3049     3070      +21     
- Misses         1159     1179      +20     
+ Partials        145      144       -1
Impacted Files Coverage Δ Complexity Δ
...ty/client/config/SecurityServiceConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../product/gateway/GatewayNotAvailableException.java 100% <ø> (ø) 0 <0> (?)
...mfaas/discovery/config/HttpsWebSecurityConfig.java 0% <0%> (ø) 0 <0> (?)
.../com/ca/apiml/security/common/error/ErrorType.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...iscovery/config/AbstractWebSecurityConfigurer.java 100% <100%> (ø) 0 <0> (?)
.../mfaas/discovery/config/HttpWebSecurityConfig.java 100% <100%> (ø) 0 <0> (?)
...va/com/ca/mfaas/product/gateway/GatewayClient.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...l/security/client/handler/RestResponseHandler.java 83.87% <100%> (ø) 0 <0> (ø) ⬇️
...y/common/error/ResourceAccessExceptionHandler.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...apicatalog/instance/InstanceInitializeService.java 79.1% <100%> (ø) 0 <0> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428cff0...368d799. Read the comment docs.

@janan07
Copy link
Contributor

janan07 commented Sep 3, 2019

Reviewed by TI

JirkaAichler
JirkaAichler previously approved these changes Sep 3, 2019
Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you everyone involved!

arxioly
arxioly previously approved these changes Sep 3, 2019
Copy link
Contributor

@arxioly arxioly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Contributor

@ilkinabdullayev ilkinabdullayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jandadav jandadav merged commit cc3f9ab into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the janda06/eurekaAuth branch September 4, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants