Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: runInBand for catalog ui tests to avoid flaky #3782

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Sep 19, 2024

Description

  • Try running the jest tests sequentially to avoid flakyness issues (needs to be addressed)
  • Update test failing in render.

Type of change

  • chore: Chore, repository cleanup, updates the dependencies.

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Pablo Hernán Carle and others added 5 commits September 19, 2024 15:50
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Hernán Carle <pablo.carle@broadcom.com>
Signed-off-by: Andrea Tabone <andrea.tabone@broadcom.com>
Copy link

sonarcloud bot commented Sep 19, 2024

@pablocarle pablocarle merged commit 41416b4 into v3.x.x Sep 19, 2024
29 checks passed
@pablocarle pablocarle deleted the reboot/fix/release-versioning branch September 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants