-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component scripts #393
Conversation
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@vvvlc @petr-galik I'm getting errors on the PR build in the API catalog component, which I've not touched and I can't work out how to get the build pipeline to produce a branch build to test the changes. Can you advise? |
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
============================================
- Coverage 70.82% 70.68% -0.14%
Complexity 12 12
============================================
Files 253 239 -14
Lines 4750 4418 -332
Branches 575 545 -30
============================================
- Hits 3364 3123 -241
+ Misses 1238 1155 -83
+ Partials 148 140 -8
Continue to review full report at Codecov.
|
Thanks to @taban03 I've managed to fix my error. The react tests are still failing, but I've been told that's in master as well, so I think this PR is ready for review. |
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Signed-off-by: stevenhorsman steven@uk.ibm.com