Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component scripts #393

Merged
merged 9 commits into from
Sep 27, 2019
Merged

Add component scripts #393

merged 9 commits into from
Sep 27, 2019

Conversation

stevenhorsman
Copy link
Member

Signed-off-by: stevenhorsman steven@uk.ibm.com

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman
Copy link
Member Author

@vvvlc @petr-galik I'm getting errors on the PR build in the API catalog component, which I've not touched and I can't work out how to get the build pipeline to produce a branch build to test the changes. Can you advise?

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #393 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #393      +/-   ##
============================================
- Coverage     70.82%   70.68%   -0.14%     
  Complexity       12       12              
============================================
  Files           253      239      -14     
  Lines          4750     4418     -332     
  Branches        575      545      -30     
============================================
- Hits           3364     3123     -241     
+ Misses         1238     1155      -83     
+ Partials        148      140       -8
Impacted Files Coverage Δ Complexity Δ
...s/gateway/error/check/SecurityTokenErrorCheck.java 80% <0%> (-12.86%) 0% <0%> (ø)
...a/mfaas/gateway/error/check/TimeoutErrorCheck.java 88.88% <0%> (-7.41%) 0% <0%> (ø)
...as/client/DiscoverableClientSampleApplication.java 33.33% <0%> (-6.67%) 0% <0%> (ø)
...as/apicatalog/instance/InstanceRefreshService.java 77.52% <0%> (-5.47%) 0% <0%> (ø)
...faas/client/api/PetControllerExceptionHandler.java 88.67% <0%> (-2.23%) 0% <0%> (ø)
...om/ca/mfaas/gateway/error/check/TlsErrorCheck.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
.../com/ca/apiml/security/common/error/ErrorType.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...a/mfaas/gateway/error/NotFoundErrorController.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ient/ws/DiscoverableClientWebSocketConfigurer.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
...handlers/ApiCatalogControllerExceptionHandler.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07bcc8...88d7b8e. Read the comment docs.

@stevenhorsman
Copy link
Member Author

Thanks to @taban03 I've managed to fix my error. The react tests are still failing, but I've been told that's in master as well, so I think this PR is ready for review.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Copy link
Contributor

@VitekVlcek-Broadcom VitekVlcek-Broadcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@VitekVlcek-Broadcom VitekVlcek-Broadcom merged commit cbca20e into master Sep 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the componentised-scripts branch September 27, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants