Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

[next] Export the Config object at top level #563

Merged
merged 4 commits into from
Mar 10, 2021
Merged

[next] Export the Config object at top level #563

merged 4 commits into from
Mar 10, 2021

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Mar 9, 2021

Fixes #543

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj changed the title Export the Config object at top level [next] Export the Config object at top level Mar 9, 2021
Copy link
Member

@gejohnston gejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea! 😋

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #563 (57babbc) into next (b1a0fad) will increase coverage by 3.85%.
The diff coverage is 94.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #563      +/-   ##
==========================================
+ Coverage   80.97%   84.82%   +3.85%     
==========================================
  Files         150      180      +30     
  Lines        7258     8856    +1598     
  Branches     1291     1599     +308     
==========================================
+ Hits         5877     7512    +1635     
+ Misses       1377     1340      -37     
  Partials        4        4              
Impacted Files Coverage Δ
packages/cmd/src/yargs/AbstractCommandYargs.ts 36.66% <ø> (ø)
packages/cmd/src/yargs/CommandYargs.ts 40.20% <50.00%> (+0.62%) ⬆️
packages/cmd/src/yargs/YargsConfigurer.ts 50.00% <50.00%> (+10.83%) ⬆️
packages/cmd/src/CommandProcessor.ts 83.52% <75.00%> (+0.32%) ⬆️
packages/imperative/src/OverridesLoader.ts 79.06% <79.16%> (-3.54%) ⬇️
packages/cmd/src/response/CommandResponse.ts 94.26% <87.71%> (-2.76%) ⬇️
packages/imperative/src/DefinitionTreeResolver.ts 95.34% <90.90%> (-1.80%) ⬇️
packages/cmd/src/profiles/CliProfileManager.ts 96.05% <91.66%> (+0.03%) ⬆️
packages/cmd/src/CommandPreparer.ts 96.84% <94.11%> (-0.34%) ⬇️
packages/imperative/src/Imperative.ts 81.89% <94.54%> (+4.11%) ⬆️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad8e71...57babbc. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@t1m0thyj t1m0thyj merged commit a740a3f into next Mar 10, 2021
@t1m0thyj t1m0thyj deleted the next-fix-543 branch March 10, 2021 16:09
@t1m0thyj t1m0thyj linked an issue Mar 11, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the Config object at top level
4 participants