This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
[next] Export the Config object at top level #563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
changed the title
Export the Config object at top level
[next] Export the Config object at top level
Mar 9, 2021
gejohnston
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
zFernand0
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea! 😋
awharn
approved these changes
Mar 10, 2021
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## next #563 +/- ##
==========================================
+ Coverage 80.97% 84.82% +3.85%
==========================================
Files 150 180 +30
Lines 7258 8856 +1598
Branches 1291 1599 +308
==========================================
+ Hits 5877 7512 +1635
+ Misses 1377 1340 -37
Partials 4 4
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543