This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
[next] Update config schema to improve IntelliSense #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
gejohnston
approved these changes
Mar 11, 2022
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov Report
@@ Coverage Diff @@
## next #751 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 197 197
Lines 10301 10302 +1
Branches 1978 1979 +1
=======================================
+ Hits 9153 9154 +1
Misses 1144 1144
Partials 4 4
Continue to review full report at Codecov.
|
awharn
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
zFernand0
approved these changes
Mar 17, 2022
t1m0thyj
changed the title
Update config schema to improve IntelliSense
[next] Update config schema to improve IntelliSense
Mar 21, 2022
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Kudos, SonarCloud Quality Gate passed! |
zFernand0
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the newly introduced schemas.
Much appreciated! 😋
This was referenced Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@next
tag before merging this PRprefixItems
property parsed byloadSchema
for thesecure
array was renamed toitems
if.properties.type
parsed byloadSchema
can now befalse
rather than an objectenum
to schema forprofiles.XXX.type
so that IntelliSense suggests known profile typesdescription
for config JSON properties so that IntelliSense shows more helpful tooltipsRemove duplicate values from IntelliSense suggestions forsecure
arrayFix VS Code not underlining unknown value fortype
propertyautoStore
boolean property to schema? YesAdd experimentalNoplugins
array property to schema?$version < 4
) schemas used in tests