Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Be more specific about NPM execution #900

Merged
merged 8 commits into from
Nov 11, 2022
Merged

Be more specific about NPM execution #900

merged 8 commits into from
Nov 11, 2022

Conversation

awharn
Copy link
Member

@awharn awharn commented Nov 9, 2022

Execute NPM directly in several Plugin interfaces.
Replace execSync with spawnSync.
Update tests to deal with this change.

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 82.70% // Head: 82.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (68750f8) compared to base (5cf170b).
Patch coverage: 72.22% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v1-lts     #900   +/-   ##
============================================
  Coverage        82.70%   82.70%           
============================================
  Files              163      163           
  Lines             7948     7945    -3     
  Branches          1454     1454           
============================================
- Hits              6573     6571    -2     
+ Misses            1371     1370    -1     
  Partials             4        4           
Impacted Files Coverage Δ
...s/imperative/src/plugins/utilities/NpmFunctions.ts 61.53% <37.50%> (-1.26%) ⬇️
...e/src/plugins/utilities/npm-interface/uninstall.ts 97.05% <100.00%> (ø)
...erative/src/plugins/utilities/runValidatePlugin.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@awharn awharn marked this pull request as ready for review November 11, 2022 15:25
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.2% 72.2% Coverage
0.0% 0.0% Duplication

@awharn awharn merged commit 8043129 into zowe-v1-lts Nov 11, 2022
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Nov 11, 2022
@github-actions github-actions bot removed the release-patch Indicates a patch to existing code has been applied label Nov 11, 2022
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Nov 11, 2022
@github-actions
Copy link

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@4.18.10

Powered by Octorelease 🚀

@awharn awharn mentioned this pull request Nov 16, 2022
@t1m0thyj t1m0thyj deleted the fix-stuff branch December 12, 2022 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants