Use cross-spawn to fix spaces in install path in v2 #961

awharn · 2023-03-22T20:16:48Z

No description provided.

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

packages/imperative/__tests__/config/cmd/report-env/EnvQuery.unit.test.ts

            const spawnError = new Error("Pretend this was thrown by spawnSync");
-            const isDirSpy = jest.spyOn(childProc, "spawnSync").mockImplementation(() => {
+            const isDirSpy = jest.spyOn(spawn, "sync").mockImplementation(() => {


Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>

codecov · 2023-03-22T20:48:54Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c54a4b9) 89.51% compared to head (b9095bb) 89.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   89.51%   89.52%   +0.01%     
==========================================
  Files         207      207              
  Lines       11259    11259              
  Branches     2507     2507              
==========================================
+ Hits        10078    10080       +2     
+ Misses       1181     1179       -2

Impacted Files	Coverage Δ
...s/imperative/src/config/cmd/report-env/EnvQuery.ts	`96.09% <100.00%> (ø)`
packages/utilities/src/ProcessUtils.ts	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

t1m0thyj

LGTM, thanks @awharn!

Should we create an issue to update other places where child_process.spawn is used in the future? For example, ProcessUtils.openInEditor could fail if the file path includes a space.

awharn · 2023-03-23T12:18:06Z

LGTM, thanks @awharn!

Should we create an issue to update other places where child_process.spawn is used in the future? For example, ProcessUtils.openInEditor could fail if the file path includes a space.

It might make sense to fix that now too.