This repository has been archived by the owner on Nov 13, 2023. It is now read-only.
Use literal "ZOWE" as env prefix for NextVerFeatures #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
I originally thought that using ImperativeConfig.instance.envVariablePrefix was the appropriate way to get the prefix for the ZOWE_V3_ERR_FORMAT variable. However, many API system tests do NOT call imperative.init(). We would be required to create very many mocks in our system tests to make such tests run successfully. That situation brought to light the possibility that any external app which uses a NextVerFeatures function, but which does not first call imperative.init(), will fail with some form of error.
This PR replaces the need for imperative.init() by simply placing the literal string "ZOWE" within the NextVerFeatures module for use as the prefix for environment variables.
How to Test
There is no new functionality in this PR. As long as automated tests run successfully, then this change should be good to release.
Review Checklist
I certify that I have:
Additional Comments
Testing of the zowe-cli v3-err-format branch cannot be completed until this imperative PR is merged and published.