-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(uss/datasets): Reset VSCode multi-select flag after Hide Profile in multi-selection #2108
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportBase: 72.68% // Head: 72.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2108 +/- ##
===============================================
+ Coverage 72.68% 72.83% +0.15%
===============================================
Files 76 77 +1
Lines 8039 8047 +8
Branches 1706 1706
===============================================
+ Hits 5843 5861 +18
+ Misses 2196 2186 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
837ab04
to
f48cf8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯 oh wow, that was unexpected. Maybe this is related to #2098 ? I tried the same steps but cannot replicate this problem when building from the branch. I also tried this w/ the VSIX and the behavior is working as expected in my environment. |
It might be related 😱 UPDATE: |
Great, thanks for confirming @zFernand0 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My label duplication was resolved after testing with #2098.
This PR LGTM! 😋
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
f0808ad
to
a432790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the changelog!
LGTM! 😋
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for fixing the merge conflicts! 🥳
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Proposed changes
This should resolve the bug where VSCode still thinks there is a multi-selection active, even though the nodes in the previous selection were deleted. This typically happens when a user uses "Hide Profile" in a multi-select operation, as it removes the nodes that were previously a part of that selection.
Release Notes
Milestone: 2.6.1
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executed