Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing question mark #2233

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add missing question mark #2233

merged 1 commit into from
Aug 13, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Aug 13, 2024

What It Does

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (c5c5df1) to head (99baf5f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2233      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         638      638              
  Lines       19103    19102       -1     
  Branches     4040     3973      -67     
==========================================
- Hits        17414    17411       -3     
- Misses       1688     1690       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andrew for the fix 👍

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

@t1m0thyj t1m0thyj merged commit d17867d into master Aug 13, 2024
19 checks passed
@t1m0thyj t1m0thyj deleted the fix-coverity-issues branch August 13, 2024 13:48
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants