Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions for peers #2287

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Update versions for peers #2287

merged 4 commits into from
Oct 3, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 3, 2024

What It Does

Updates peer dependencies to ^8.0.0, dropping support for next-tagged versions

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@awharn awharn self-assigned this Oct 3, 2024
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn for finding this and fixing it so quickly!

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments re: changelogs w/ request for minor edits.

@@ -2,6 +2,10 @@

All notable changes to the Zowe CLI test utils package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please end sentence w/ a period.
Can we say "... for versions tagged next"? If accurate, I think it'd be more clear.

@@ -2,6 +2,10 @@

All notable changes to the Zowe core SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe provisioning SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS workflows SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS console SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS jobs SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS logs SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,9 @@

All notable changes to the Zowe z/OSMF SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,9 @@

All notable changes to the Zowe z/OS TSO SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

@@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS USS SDK package will be documented in this file.

## Recent Changes

- BugFix: Updated peer dependencies to `^8.0.0`, dropping support for next-tagged versions [#2287](https://github.com/zowe/zowe-cli/pull/2287)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as first comment.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (69005d4) to head (244ba73).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2287    +/-   ##
========================================
  Coverage   91.24%   91.24%            
========================================
  Files         628      628            
  Lines       17868    17868            
  Branches     3736     3842   +106     
========================================
  Hits        16303    16303            
  Misses       1564     1564            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
@awharn awharn requested a review from anaxceron October 3, 2024 15:39
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awharn!

@t1m0thyj t1m0thyj merged commit fab285f into master Oct 3, 2024
19 checks passed
@t1m0thyj t1m0thyj deleted the fix-peers branch October 3, 2024 17:04
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants