Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No UI indicator presented to end user after clicking "Pull from Mainframe" #2484

Closed
traeok opened this issue Sep 28, 2023 · 8 comments · Fixed by #2865
Closed

No UI indicator presented to end user after clicking "Pull from Mainframe" #2484

traeok opened this issue Sep 28, 2023 · 8 comments · Fixed by #2865
Assignees
Labels
bug Something isn't working good first issue Good for newcomers priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Milestone

Comments

@traeok
Copy link
Member

traeok commented Sep 28, 2023

Describe the bug

There is no indication that the "Pull from Mainframe" action is ongoing once a user clicks it. We should show some sort of indication, such as a status bar indicator, to keep end users up to date.

To Reproduce

  1. Search for a data set
  2. Right-click on a data set member -> "Pull from Mainframe"
  3. Notice that no UI indicator appears.

Expected behavior

Users should see some indication that we are actively pulling data from the mainframe.

@traeok traeok added the bug Something isn't working label Sep 28, 2023
@github-actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@JTonda JTonda added good first issue Good for newcomers priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases labels Oct 10, 2023
@zaidmstrr
Copy link
Contributor

Can I work on the issue.

@t1m0thyj
Copy link
Member

Can I work on the issue.

@zaidmstrr Sure, I have assigned you to the issue, feel free to work on it 🙂

@t1m0thyj t1m0thyj moved this from New Issues to Low Priority in Zowe Explorer for VS Code Dec 26, 2023
@Ash-2k3
Copy link
Contributor

Ash-2k3 commented Apr 14, 2024

Hi @t1m0thyj, can you please assign me this issue ? I'd love to work on it !

@t1m0thyj t1m0thyj assigned Ash-2k3 and unassigned zaidmstrr Apr 15, 2024
@t1m0thyj
Copy link
Member

@Ash-2k3 Sure, I have assigned you the issue since it has not been worked on for 6 months, feel free to work on it 🙂

@Ash-2k3
Copy link
Contributor

Ash-2k3 commented Apr 19, 2024

Thanks @t1m0thyj, I have started working on it and I began with setting things up in my local machine, I am facing trouble with populating dummy data sets. I tried following this wiki https://github.com/zowe/zowe-explorer-vscode/wiki/Developer-Setup#test-profile-data. But it didn't really help me. I'd appreciate any help on this, Thanks!

@t1m0thyj
Copy link
Member

@Ash-2k3 Currently the testProfileData is unused and the only integration tests we actively maintain are for Theia: https://github.com/zowe/zowe-explorer-vscode/wiki/Developer-Setup#run-zowe-explorer-regression-tests-for-theia

If you have made a fix locally and verified that unit tests are passing, then feel free to open a PR 🙂

@Ash-2k3
Copy link
Contributor

Ash-2k3 commented Apr 22, 2024

@t1m0thyj In that case, I think the wiki should be updated :). Anyways, I have opened a PR for this, but I am a bit skeptical about my approach since I couldn't really test my changes and also because I am new to this codebase, so I am not really used to coding pattern. But I do plan to get used to it overtime 😀. Thanks!

And also is there any issue which you would suggest me to work on after PR of this one gets merged ?

JillieBeanSim added a commit that referenced this issue Apr 25, 2024
Fix #2484: Added Status bar to indicate data is being pulled from mainframe.
@github-project-automation github-project-automation bot moved this from Low Priority to Closed in Zowe Explorer for VS Code Apr 25, 2024
@JillieBeanSim JillieBeanSim added this to the v2.16.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Projects
None yet
6 participants