-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zowe deps to fix handling of invalid ds member names #2807
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## maintenance #2807 +/- ##
===============================================
- Coverage 93.29% 93.29% -0.01%
===============================================
Files 103 103
Lines 10655 10665 +10
Branches 2316 2231 -85
===============================================
+ Hits 9941 9950 +9
- Misses 713 714 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
6654481
to
ecf5611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 😋
Thanks for updating the icons too 😋
63b12e3
to
ecf5611
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com> Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
ecf5611
to
5edcd3e
Compare
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
f1f13f0
to
69876ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
69876ad
to
e4ee8ce
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @t1m0thyj
Proposed changes
Improves the way that invalid ds member names are handled. Before we tried to parse the invalid member names and replace control characters with �, which was prone to edge case problems. Now we stop parsing members after the first invalid member name is encountered, and add a fake member entry at the end that says "N members with errors" for the ones we are unable to display.
Release Notes
Milestone: 2.15.3
Changelog: Fixed error that could occur when listing data set members that contain control characters in the name
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments