Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI dependencies for v1-lts #2934

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Update CLI dependencies for v1-lts #2934

merged 4 commits into from
Jun 12, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jun 4, 2024

Proposed changes

Release Notes

Milestone: 1.22.8

Changelog: Update dependencies for technical currency purposes

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
traeok
traeok previously approved these changes Jun 4, 2024
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy

@t1m0thyj t1m0thyj requested a review from adam-wolfe June 4, 2024 18:43
zFernand0
zFernand0 previously approved these changes Jun 4, 2024
anaxceron
anaxceron previously approved these changes Jun 4, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment, otherwise this is good to go as far as I'm concerned @t1m0thyj.

packages/zowe-explorer/CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj dismissed stale reviews from anaxceron, zFernand0, and traeok via 7b759b3 June 4, 2024 19:29
traeok
traeok previously approved these changes Jun 4, 2024
@t1m0thyj t1m0thyj self-assigned this Jun 4, 2024
anaxceron
anaxceron previously approved these changes Jun 4, 2024
Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t1m0thyj t1m0thyj added this to the v1.22.8 milestone Jun 4, 2024
JillieBeanSim
JillieBeanSim previously approved these changes Jun 11, 2024
Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t1m0thyj

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t1m0thyj t1m0thyj marked this pull request as draft June 11, 2024 19:50
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj dismissed stale reviews from JillieBeanSim and anaxceron via 810d763 June 12, 2024 19:28
@t1m0thyj t1m0thyj marked this pull request as ready for review June 12, 2024 19:29
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the CLI version (again) 😋

LGTM! 😋

I believe this is be good to be merged ASAP since the Zowe V1 release is now live 😋

@zFernand0 zFernand0 merged commit 7f97636 into v1-lts Jun 12, 2024
17 checks passed
@zFernand0 zFernand0 deleted the chore/update-cli-v1 branch June 12, 2024 20:06
Copy link

Release succeeded for the v1-lts branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants