Update certificateService.c #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JoeNemo <joe.devlin@gmail.com> Signed-off-by: JoeNemo <joe.devlin@gmail.com>
Martin-Zeithaml
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
If there is no problem with copyright, this type of comment is better:
4100 0028 | LA R0,X'28' Slot x'28'
8900 0002 | SLL R0,X'2' Shift left 2 bits = * 4 => x'A0'
58F0 0010 | L R15,X'10' CVT
58FF 0220 | L R15,X'220'(,R15) CSRTABLE
58FF 0028 | L R15,X'28'(,R15) SAF
1EF0 | ALR R15,R0 Add slot offset x'A0' to get IRRSIM00
58FF 0000 | L R15,X'0'(,R15) Load the address
07FF | BCR X'F',R15 Go
LG for parameter list should be ok, you are right, it is already a pointer.
|
Can we kill this PR because merge happened in some other PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JoeNemo joe.devlin@gmail.com
Signed-off-by: JoeNemo joe.devlin@gmail.com
Proposed changes
Correct bad pointer dereferencing in getting pointer to IRRSIM00 and provide some documentation of how and why.
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zss/issues if any]
#544
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
Testing
We will be testing with achmelo on his system before mering.