include benches for crc crate software implementation to compare against crc32c #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update benchmarks to include comparisons against the more generic and purely software implementation from the crc crate.
I refactored the way
benchmark_group
s were named as they were previously creating redundant names like:crc32_update_megabytes/crc32_update_megabytes
Now they are named like
1mb/crc32c
This also sets us up to name the new benchmarks like
1mb/crc_crate
I also noticed that the definition of 1 megabyte was not consistent with the definition used for kilobyte.
So I changed all megabyte benches to use 1024 * 1024 instead of 1000 * 1000.
All the original benches have functionally equivalent benches just under new names.
I removed:
Because it was causing a warning in Cargo.toml due to being ignored and having no effect.
I think this sort of config is supposed to go in
.cargo/config.toml
would you rather me move it there instead of delete it?