-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Github Deployments #26
Conversation
YES this is awesome @paulirish! Can't wait to upgrade 🙌 |
I think this looks really good. Only thing I would add is possibly adding a second value of Either way, awesome work! |
b6ae84c
to
ebce5f0
Compare
Works for me. Done. Also added a fix that means pull requests based on branches on other remotes can work now. Beforehand the branch clone failed because it wasn't local to |
Thanks for this @paulirish, nice work! Really like how the deployments look in the GH ui, much more visible/usable than commit statuses. Good catch on the remote branch issue, glad to get that fix in there. 👍 On the alias name - I think I prefer the branch name over a PR number but I'm definitely open to feedback/thoughts on that. Could go either way tbh. Perhaps one day this could be configurable (somehow 😛 ). I'll be testing this out a little bit, but it should be good to merge! |
This reverts commit e8a522d.
sgtm. reverted that for now. cheers. thanks for taking a look. |
@paulirish Everything looks great, I'm going to merge this in. Really appreciate your work on this feature! 👏 |
fixes #17
This was pretty straightforward. Here's an example PR where I was using this: paulirish/hello-world#3 (comment)
Pending State:
Completed:
And I definitely prefer this setup based on deployments rather than commit statuses. It's very visible, whereas once the commit status's all pass, that gets hidden by Github.
Configurability:
description
field in for 1) creating a deployment and 2) updating a pending deployment, but it doesn't appear to affect the user-visible UI. shrugcc @mxstbr
As a driveby I changed the alias from branch ref to PR number. I can see the argument for keeping things as they were, so no big deal if you guys want to revert that. :)