1.18.1 support #58
Merged
1.18.1 support #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: In this commit, ExtensionPoints are currently broken due to a FML API change.
|
-- missing file exception when i try to build it myself? |
|
Odd... I'll give it a look. I didn't bring over the newer Gradle version from my Eclipse build environment so I wonder if that might be the cause. |
|
@skedgyedgy I ran into the same problem but the issue should be resolved now. I updated the PR's Gradle version and the mod now builds properly from the command line. |
TVince0
approved these changes
Jul 18, 2022
zsawyer
reviewed
Jan 24, 2023
| @@ -85,7 +85,7 @@ public void preInit() { | |||
| ModLoadingContext context = ModLoadingContext.get(); | |||
| context.registerExtensionPoint(IExtensionPoint.DisplayTest.class | |||
| , () -> new IExtensionPoint.DisplayTest( | |||
| () -> FMLNetworkConstants.IGNORESERVERONLY, | |||
| () -> "ANY", | |||
zsawyer
reviewed
Jan 24, 2023
| @@ -104,7 +104,7 @@ public void preInit() { | |||
| ModLoadingContext context = ModLoadingContext.get(); | |||
| context.registerExtensionPoint(IExtensionPoint.DisplayTest.class | |||
| , () -> new IExtensionPoint.DisplayTest( | |||
| () -> FMLNetworkConstants.IGNORESERVERONLY, | |||
| () -> "ANY", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Minecraft 1.18.1. Initial tests so far have worked as expected. I've been using this patch for a while with several people using a MC 1.18.1 server and Mumble 1.3.4 and so far it has worked fine.
Changes made in this PR: