fix: Fixed App Connector Group lss_app_connector_group (#590)

Author: willguibr

CHANGELOG.md

@@ -4,23 +4,23 @@
 
 ### Notes
 
-- Release date: **(August, 222025)**
+- Release date: **(August, 2025)**
 - Supported Terraform version: **v1.x**
 
 ### NEW - RESOURCES AND DATA SOURCES
 
 The following new resources have been introduced:
 
-- [PR #588](https://github.com/zscaler/terraform-provider-zia/pull/588) - Added and resource``zpa_c2c_ip_ranges`` - Added C2C IP Ranges
-- [PR #588](https://github.com/zscaler/terraform-provider-zia/pull/588) - Added and resource``zpa_private_cloud_group`` - Added Private Cloud Group
-- [PR #588](https://github.com/zscaler/terraform-provider-zia/pull/588) - Added and resource``zpa_user_portal_controller`` - Added User Portal Controller
-- [PR #588](https://github.com/zscaler/terraform-provider-zia/pull/588) - Added and resource``zpa_user_portal_link`` - Added User Portal Link
+- [PR #588](https://github.com/zscaler/terraform-provider-zpa/pull/588) - Added and resource``zpa_c2c_ip_ranges`` - Added C2C IP Ranges
+- [PR #588](https://github.com/zscaler/terraform-provider-zpa/pull/588) - Added and resource``zpa_private_cloud_group`` - Added Private Cloud Group
+- [PR #588](https://github.com/zscaler/terraform-provider-zpa/pull/588) - Added and resource``zpa_user_portal_controller`` - Added User Portal Controller
+- [PR #588](https://github.com/zscaler/terraform-provider-zpa/pull/588) - Added and resource``zpa_user_portal_link`` - Added User Portal Link
 
 ### NEW - DATA SOURCES
 
 The following new data sources have been introduced:
 
-- [PR #452](https://github.com/zscaler/terraform-provider-zia/pull/452) - Added and datasource``zpa_private_cloud_controller`` - Retrieves private cloud controller.
+- [PR #452](https://github.com/zscaler/terraform-provider-zpa/pull/452) - Added and datasource``zpa_private_cloud_controller`` - Retrieves private cloud controller.
 
 ## 4.1.14 (July, 14 2025)
 

GNUmakefile

@@ -55,14 +55,14 @@ test\:integration\:zpa:
 build13: GOOS=$(shell go env GOOS)
 build13: GOARCH=$(shell go env GOARCH)
 ifeq ($(OS),Windows_NT)  # is Windows_NT on XP, 2000, 7, Vista, 10...
-build13: DESTINATION=$(APPDATA)/terraform.d/plugins/$(ZPA_PROVIDER_NAMESPACE)/4.2.0/$(GOOS)_$(GOARCH)
+build13: DESTINATION=$(APPDATA)/terraform.d/plugins/$(ZPA_PROVIDER_NAMESPACE)/4.2.1/$(GOOS)_$(GOARCH)
 else
-build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(ZPA_PROVIDER_NAMESPACE)/4.2.0/$(GOOS)_$(GOARCH)
+build13: DESTINATION=$(HOME)/.terraform.d/plugins/$(ZPA_PROVIDER_NAMESPACE)/4.2.1/$(GOOS)_$(GOARCH)
 endif
 build13: fmtcheck
 	@echo "==> Installing plugin to $(DESTINATION)"
 	@mkdir -p $(DESTINATION)
-	go build -o $(DESTINATION)/terraform-provider-zpa_v4.2.0
+	go build -o $(DESTINATION)/terraform-provider-zpa_v4.2.1
 
 vet:
 	@echo "==> Checking source code against go vet and staticcheck"

docs/guides/release-notes.md

@@ -12,10 +12,20 @@ Track all ZPA Terraform provider's releases. New resources, features, and bug fi
 
 ---
 
-``Last updated: v4.2.0``
+``Last updated: v4.2.1``
 
 ---
 
+## 4.2.1 (September, 5 2025)
+
+### Notes
+
+- Release date: **(September, 5 2025)**
+- Supported Terraform version: **v1.x**
+
+### Bug Fixes
+[PR #590](https://github.com/zscaler/terraform-provider-zpa/pull/590) - Fixed `zpa_app_connector_group` resource attribute `lss_app_connector_group` due to API issues.
+
 ## 4.2.0 (August, 22 2025)
 
 ### Notes

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/hashicorp/terraform-plugin-docs v0.21.0
 	github.com/hashicorp/terraform-plugin-sdk v1.17.2
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.37.0
-	github.com/zscaler/zscaler-sdk-go/v3 v3.6.1
+	github.com/zscaler/zscaler-sdk-go/v3 v3.6.4
 )
 
 require (

go.sum

@@ -410,8 +410,8 @@ github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5
 github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
 github.com/stretchr/testify v1.7.2/go.mod h1:R6va5+xMeoiuVRoj+gSkQ7d3FALtqAAGI1FQKckRals=
-github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
-github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+github.com/stretchr/testify v1.11.0 h1:ib4sjIrwZKxE5u/Japgo/7SJV3PvgjGiRNAvTVGqQl8=
+github.com/stretchr/testify v1.11.0/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
 github.com/ulikunitz/xz v0.5.8/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
 github.com/vmihailenco/msgpack v3.3.3+incompatible/go.mod h1:fy3FlTQTDXWkZ7Bh6AcGMlsjHatGryHQYUTf1ShIgkk=
 github.com/vmihailenco/msgpack v4.0.4+incompatible h1:dSLoQfGFAo3F6OoNhwUmLwVgaUXK79GlxNBwueZn0xI=
@@ -445,8 +445,8 @@ github.com/zclconf/go-cty-debug v0.0.0-20191215020915-b22d67c1ba0b/go.mod h1:ZRK
 github.com/zclconf/go-cty-debug v0.0.0-20240509010212-0d6042c53940 h1:4r45xpDWB6ZMSMNJFMOjqrGHynW3DIBuR2H9j0ug+Mo=
 github.com/zclconf/go-cty-debug v0.0.0-20240509010212-0d6042c53940/go.mod h1:CmBdvvj3nqzfzJ6nTCIwDTPZ56aVGvDrmztiO5g3qrM=
 github.com/zclconf/go-cty-yaml v1.0.2/go.mod h1:IP3Ylp0wQpYm50IHK8OZWKMu6sPJIUgKa8XhiVHura0=
-github.com/zscaler/zscaler-sdk-go/v3 v3.6.1 h1:7xSBe0n9Ibk5nLTPZxfVg2wiXfzD1VRWq+2Rd2CjQHc=
-github.com/zscaler/zscaler-sdk-go/v3 v3.6.1/go.mod h1:8WW/Mj/gT57JqmsmxXaJwm/p0FMqeD76Z374oiw5z54=
+github.com/zscaler/zscaler-sdk-go/v3 v3.6.4 h1:i0XKbeDtDrMcaSw86j3ouE1xt4bepRrXRXiCfVNh4CU=
+github.com/zscaler/zscaler-sdk-go/v3 v3.6.4/go.mod h1:q6Zma3E3la4VD3DrMz8mUMeTI/OFMJ63GGxcYMVrMNE=
 go.abhg.dev/goldmark/frontmatter v0.2.0 h1:P8kPG0YkL12+aYk2yU3xHv4tcXzeVnN+gU0tJ5JnxRw=
 go.abhg.dev/goldmark/frontmatter v0.2.0/go.mod h1:XqrEkZuM57djk7zrlRUB02x8I5J0px76YjkOzhB4YlU=
 go.opencensus.io v0.21.0/go.mod h1:mSImk1erAIZhrmZN+AvHh14ztQfjbGwt4TtuofqLduU=

zpa/resource_zpa_app_connector_group.go

@@ -114,7 +114,6 @@ func resourceAppConnectorGroup() *schema.Resource {
 			"lss_app_connector_group": {
 				Type:        schema.TypeBool,
 				Optional:    true,
-				Computed:    true,
 				Description: "Whether or not the App Connector Group is configured for the Log Streaming Service (LSS)",
 			},
 			"tcp_quick_ack_app": {
@@ -237,16 +236,28 @@ func resourceAppConnectorGroupRead(ctx context.Context, d *schema.ResourceData,
 		service = service.WithMicroTenant(microTenantID)
 	}
 
-	resp, _, err := appconnectorgroup.Get(ctx, service, d.Id())
+	// Use GetAll to get the complete list and find the resource by ID
+	// This avoids the individual Get API call which returns incorrect lssAppConnectorGroup values
+	list, _, err := appconnectorgroup.GetAll(ctx, service)
 	if err != nil {
-		if errResp, ok := err.(*errorx.ErrorResponse); ok && errResp.IsObjectNotFound() {
-			log.Printf("[WARN] Removing app connector group %s from state because it no longer exists in ZPA", d.Id())
-			d.SetId("")
-			return nil
-		}
 		return diag.FromErr(err)
 	}
 
+	// Find the specific resource by ID in the list
+	var resp *appconnectorgroup.AppConnectorGroup
+	for _, item := range list {
+		if item.ID == d.Id() {
+			resp = &item
+			break
+		}
+	}
+
+	if resp == nil {
+		log.Printf("[WARN] Removing app connector group %s from state because it no longer exists in ZPA", d.Id())
+		d.SetId("")
+		return nil
+	}
+
 	log.Printf("[INFO] Getting app connector group:\n%+v\n", resp)
 	_ = d.Set("name", resp.Name)
 	_ = d.Set("city_country", resp.CityCountry)