Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added and Fixed ZIA integration tests #112

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

willguibr
Copy link
Member

@willguibr willguibr commented Jun 20, 2024

Provide a general summary of your changes in the title above. You should
remove this overview, any sections and any section descriptions you
don't need below before submitting. There isn't a strict requirement to
use this template if you can structure your description and still cover
these points.

Description

Describe your changes in detail through motivation and context. Why is
this change required? What problem does it solve? If it fixes an open
issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your
change affects other parts of the code. Automated tests are generally
expected and changes without tests should explain why they aren't
required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented and stable APIs.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (298ca20) to head (1ba9d7e).

Files Patch % Lines
zscaler/zia/firewall.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   70.14%   69.46%   -0.69%     
==========================================
  Files          54       26      -28     
  Lines        4193     1575    -2618     
==========================================
- Hits         2941     1094    -1847     
+ Misses       1252      481     -771     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willguibr willguibr merged commit fd82dc8 into master Jun 20, 2024
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
### [0.5.1](v0.5.0...v0.5.1) (2024-06-20)

### Bug Fixes

* Added and Fixed ZIA integration tests ([#112](#112)) ([fd82dc8](fd82dc8))
Copy link

🎉 This PR is included in version 0.5.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request In development Under active development released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant