Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging during application shutdown #11

Closed
richardeakin opened this issue Feb 4, 2014 · 0 comments · Fixed by #12
Closed

Logging during application shutdown #11

richardeakin opened this issue Feb 4, 2014 · 0 comments · Fixed by #12

Comments

@richardeakin
Copy link

I noticed that with the current way that mlogger is managed by a unique_ptr, it can lead to crashes when trying to log in destructors that stem for static data, since that mlogger might already have been destroyed.

I was wondering what your opinions are on having it leak until the application is destroyed. I've made this modification locally and it allows me to log in some really deep parts of my project, but of course it will show up on a leak tool like valgrind. I've always been of the opinion that this is one exception to the rule, anyway. Here's the commit if your interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant