Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use COMPDUMPFILE variable as completion dump file location #98

Merged
merged 2 commits into from
Dec 28, 2015
Merged

use COMPDUMPFILE variable as completion dump file location #98

merged 2 commits into from
Dec 28, 2015

Conversation

wonmin82
Copy link
Contributor

I have slightly changed antigen-apply() function to use $COMPDUMPFILE variable as completion dump file location.

I have tested it, I think it works well. Is there any problem that this code could cause?

@wonmin82
Copy link
Contributor Author

This code could resolve #97.

@desyncr
Copy link
Member

desyncr commented Jan 4, 2015

Tested and seems to work just fine. 👍

@pedromaltez
Copy link

Thanks for looking into this! It was killing me that I was setting the variable but nothing was happening.

@sharat87
Copy link
Member

Implementation looks good to me, but should we add an ANTIGEN_ prefix to the variable name? It will be both explicit in intent and will avoid potential future conflicts with other projects.

Thank you for the PR and sorry for the delay :)

@wonmin82
Copy link
Contributor Author

Agreed. I've added prefix to the variable name. Thank you for the review.

@wonmin82
Copy link
Contributor Author

wonmin82 commented Oct 5, 2015

Can anyone merge this PR? If there is no problem..

@desyncr
Copy link
Member

desyncr commented Oct 5, 2015

I don't think there are repo collaborators who can merge PRs and @sharat87 has been away for a while.

desyncr added a commit that referenced this pull request Dec 28, 2015
use ANTIGEN_COMPDUMPFILE variable as completion dump file location
@desyncr desyncr merged commit 7aaefa3 into zsh-users:master Dec 28, 2015
@desyncr
Copy link
Member

desyncr commented Dec 28, 2015

We may have to update the README.md or wiki to document the new configuration variable.
Thanks @wonmin82 for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants