Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OCaml 5, update to boxroots 0.3 #136

Merged
merged 29 commits into from
Mar 29, 2024
Merged

Support OCaml 5, update to boxroots 0.3 #136

merged 29 commits into from
Mar 29, 2024

Conversation

zshipko
Copy link
Owner

@zshipko zshipko commented Jun 5, 2023

No description provided.

sys/src/runtime.rs Outdated Show resolved Hide resolved
@Lupus
Copy link

Lupus commented Mar 22, 2024

Quick question regarding "3307d81 refactor: remove ocaml-interop dependency" - will it still be possible to integrate with ocaml-interop externally from ocaml-rs?

I'm asking because we actively use CamlRef in our bindings, which leverages ocaml::interop::DynBox to safely store pointers to Rust values in OCaml side (in regards to OCaml moving this value around in its heap).

@zshipko
Copy link
Owner Author

zshipko commented Mar 22, 2024

@Lupus I am not opposed to bringing the ocaml-interop compatibility back once it gets updated, I just wanted to make some progress on fixing this PR up in the meantime. I don't think it would be possible to implement FromValue/ToValue for the ocaml-interop types outside of this crate without creating some kind of type wrapper.

@zshipko zshipko marked this pull request as ready for review March 23, 2024 00:32
@zshipko zshipko merged commit cbdaadf into master Mar 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants