Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added django 2.2 support #28

Closed
wants to merge 2 commits into from
Closed

Added django 2.2 support #28

wants to merge 2 commits into from

Conversation

lino
Copy link

@lino lino commented Apr 21, 2019

tox tests are passing

@zsoldosp
Copy link
Owner

Hi @lino, thanks for the PR, it looks good to me! 👍

When new releases are made, the following changes also should happen

  • bump the version in django_currentuser/__init__.py - in this case, only the build number (last) needs to increase, as no API changes or features were introduced/removed
  • update .travis.yml - just running tox2travis.py should take care of that (or maybe need to pipe the output into .travis.yml)
  • update the README.md with release notes - however, as I see it has been, ahem, a bit behind so we should catch up on that

However, I recall that for releases there was a problem with 3.7 python recently, cc'ing @kairichard and @Eorhim for input on that

@zsoldosp zsoldosp mentioned this pull request Apr 24, 2019
@@ -4,6 +4,7 @@ envlist =
py{27,34,35,36}-django111,
py{34,35,36}-django20,
Copy link
Contributor

@Eorhim Eorhim Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.4 reached end-of-life. No need to test for it anymore. https://devguide.python.org/#status-of-python-branches

Likewise Django 2.0 reached end-of-extended. https://www.djangoproject.com/download/#supported-versions

See https://docs.djangoproject.com/en/2.2/faq/install/#what-python-version-can-i-use-with-django for the compatibility matrix.

@@ -50,6 +50,7 @@ def matrix(self):
py34='3.4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End-of-life for Python 3.4

@Eorhim
Copy link
Contributor

Eorhim commented Apr 25, 2019

@lino, @zsoldosp

The problem with Python 3.7 was solved in fe951cf6807beb9671734a2a13ffb07391fa7a81 by cutting out some outdated build system and using the Travis functionality directly.

Unfortunately tox2travis.py wasn't updated. So if you want to use that script to generate the .travis.yml configuration, you will loose the packaging ability.

@Eorhim
Copy link
Contributor

Eorhim commented May 7, 2019

@lino: I close this pull request, because I extended your work in pull request #29.

Thank you for pushing the project forward with your work.

@Eorhim Eorhim closed this May 7, 2019
This was referenced Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants