-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added django 2.2 support #28
Conversation
Hi @lino, thanks for the PR, it looks good to me! 👍 When new releases are made, the following changes also should happen
However, I recall that for releases there was a problem with 3.7 python recently, cc'ing @kairichard and @Eorhim for input on that |
@@ -4,6 +4,7 @@ envlist = | |||
py{27,34,35,36}-django111, | |||
py{34,35,36}-django20, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.4 reached end-of-life. No need to test for it anymore. https://devguide.python.org/#status-of-python-branches
Likewise Django 2.0 reached end-of-extended. https://www.djangoproject.com/download/#supported-versions
See https://docs.djangoproject.com/en/2.2/faq/install/#what-python-version-can-i-use-with-django for the compatibility matrix.
@@ -50,6 +50,7 @@ def matrix(self): | |||
py34='3.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End-of-life for Python 3.4
The problem with Python 3.7 was solved in fe951cf6807beb9671734a2a13ffb07391fa7a81 by cutting out some outdated build system and using the Travis functionality directly. Unfortunately |
tox tests are passing