Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deleted messages (delete_message events) #120

Closed
gnprice opened this issue May 26, 2023 · 1 comment · Fixed by #766
Closed

Handle deleted messages (delete_message events) #120

gnprice opened this issue May 26, 2023 · 1 comment · Fixed by #766
Assignees
@PIG208
Labels
a-api Implementing specific parts of the Zulip server API
Milestone
Beta 3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented May 26, 2023

https://zulip.com/api/get-events#delete_message

Related issue:
@gnprice gnprice added the m-beta label May 26, 2023
@chrisbobbe chrisbobbe mentioned this issue May 26, 2023
Closed
@gnprice gnprice mentioned this issue May 26, 2023
Open
72 tasks
@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label May 26, 2023
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice removed the m-beta label May 27, 2023
@gnprice
Copy link
Member Author

gnprice commented Jul 6, 2023

We now parse these events, since #212. The remaining task in this issue is to handle them in [PerAccountStore.handleEvent], by updating our data structures that are affected.

@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@gnprice gnprice modified the milestones: Launch, B2: Summer 2024 May 9, 2024
@PIG208 PIG208 self-assigned this Jun 26, 2024
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 26, 2024
@PIG208
message: Handle message deletion event.
9b86848 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@PIG208 PIG208 linked a pull request Jun 26, 2024 that will close this issue
message: Handle message deletion event. #766
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle message deletion event.
c8102e3 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle message deletion event.
e71e63e 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle message deletion event.
6dc2eca 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle message deletion event.
90b2e6a 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 27, 2024
@PIG208
message: Handle message deletion event.
6aa641d 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Jun 28, 2024
@PIG208
message: Handle message deletion event.
a75eea6 
When handling a message deletion event, we just simply remove the
messages from the per account store and wipe them from the message list
view if they are present.

Because message deletion can affect what items are to be seen (date
separator, recipient header, etc.), if the view has any message deleted, a
`_reprocessAll` call is triggered. It would be ideal to just removed the
affected items for better performance.

Fixes zulip#120.

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
@gnprice gnprice closed this as completed in c4ca1ab Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PIG208 PIG208

Labels
a-api Implementing specific parts of the Zulip server API
Projects
Flutter app
Status: Done
Milestone
Beta 3: Summer 2024
Development

Successfully merging a pull request may close this issue.

message: Handle message deletion event. PIG208/zulip-flutter
2 participants
@gnprice @PIG208