Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Review unhandled events for beta #308

Closed
gnprice opened this issue Sep 22, 2023 · 1 comment
Closed

☂️ Review unhandled events for beta #308

gnprice opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Sep 22, 2023

This is a subset of:

For the beta milestone, we won't handle all the events in the Zulip API. But we should review the list of them and identify any that should be handled for the beta (and aren't already).

We'll then file issues for those, in the beta milestone.

@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels Sep 22, 2023
@gnprice gnprice added this to the Beta milestone Sep 22, 2023
@gnprice gnprice self-assigned this Sep 22, 2023
@gnprice
Copy link
Member Author

gnprice commented Oct 31, 2023

Done. See #135 for details.

It turns out we're nearly done with the events we'll want for the beta! The main such issue, which I just filed after this review, is:

which calls for handling the event types subscription, user_topic, and muted_topics which is a deprecated form of the latter.

There's also one we already had in the tracker:

though that's in the back half of the beta milestone, where I'd feel pretty OK with a beta that left it out.

@gnprice gnprice closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: Done
Development

No branches or pull requests

1 participant