Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle muted streams and topics #346

Closed
gnprice opened this issue Oct 31, 2023 · 0 comments · Fixed by #423
Closed

Handle muted streams and topics #346

gnprice opened this issue Oct 31, 2023 · 0 comments · Fixed by #423
Assignees
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Oct 31, 2023

Not to be confused with muted users, #296. (The mechanisms are quite different, so that's an entirely independent task.)

This means:

  • Track which streams are muted, with subscription events and the corresponding initial data.
  • Track which topics are muted and which are unmuted or followed — i.e., the user's topic visibility policies — with user_topic events, muted_topics events for older servers, and the corresponding initial data.
    • See the reducer implementation in src/mute/muteModel.js in zulip-mobile; we should be able to basically transcribe that.
  • Implement getters for that data with appropriate logic to combine the stream-level and topic-level values.
    • See the getters in src/mute/muteModel.js in zulip-mobile, and match their logic.
  • Use the muting/visibility-policy information to control…
    • … which messages are shown in stream narrows and the all-messages narrow.
      • See getShownMessagesForNarrow in zulip-mobile's src/chat/narrowsSelectors.js.
    • …which messages are included in unread counts, for the various places they appear in the UI.
      • This will be done on the Unreads model class. Our various UI should already be calling methods there to get these counts.
    • …which topics and streams are included in the inbox view ui: Add "inbox" view #117.
    • …how topics are shown in a list of topics in a stream (if we have that screen by the time we take on this issue).

We'll also want to give the user the ability to change which streams are muted, and which topics are muted or unmuted or followed. That'll be a separate followup task.

@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) labels Oct 31, 2023
@gnprice gnprice added this to the Beta milestone Oct 31, 2023
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 3, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 3, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 6, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 6, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 7, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
sirpengi added a commit to sirpengi/zulip-flutter that referenced this issue Nov 9, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
gnprice pushed a commit to sirpengi/zulip-flutter that referenced this issue Nov 9, 2023
These helpers do not account for muted topics and streams,
those are left for zulip#346.
@gnprice gnprice self-assigned this Nov 22, 2023
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 29, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant