Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

content: Translate web's CSS for code blocks in dark theme #749

Closed
chrisbobbe opened this issue Jun 18, 2024 · 0 comments · Fixed by #756
Closed

content: Translate web's CSS for code blocks in dark theme #749

chrisbobbe opened this issue Jun 18, 2024 · 0 comments · Fixed by #756
Assignees
@chrisbobbe
Labels
a-design Visual and UX design
Milestone
Beta 3: Summer 2024

Comments

@chrisbobbe
Copy link
Collaborator

Related: #95
@chrisbobbe chrisbobbe added the a-design Visual and UX design label Jun 18, 2024
@chrisbobbe chrisbobbe self-assigned this Jun 18, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jun 18, 2024
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jun 20, 2024
@chrisbobbe
content [nfc]: Name CodeBlockTextStyles's factory constructor "light"
481e1a3 
We're about to add a "dark", for zulip#749 / zulip#95 dark theme.
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jun 20, 2024
@chrisbobbe
content: Implement Pygments Monokai, for upcoming dark theme
f289473 
For dark theme, web currently uses a mix of Pygments Monokai and
Pygments Default. Mixing in Pygments Default seems accidental, so
here we just use pure Pygments Monokai. Discussion:
  https://chat.zulip.org/#narrow/stream/431-redesign-project/topic/code.20span.20colors/near/1832283

LICENSE and AUTHORS files downloaded from:
  https://github.com/pygments/pygments/blob/f64833d9d/LICENSE
  https://github.com/pygments/pygments/blob/f64833d9d/AUTHORS

(I've included AUTHORS because LICENSE refers to it.)

Fixes: zulip#749
Related: zulip#95
@chrisbobbe chrisbobbe mentioned this issue Jun 20, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jun 26, 2024
@chrisbobbe
content [nfc]: Name CodeBlockTextStyles's factory constructor "light"
65380e3 
We're about to add a "dark", for zulip#749 / zulip#95 dark theme.
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jun 26, 2024
@chrisbobbe
content: Implement Pygments Monokai, for upcoming dark theme
af6add9 
For dark theme, web currently uses a mix of Pygments Monokai and
Pygments Default. Mixing in Pygments Default seems accidental, so
here we just use pure Pygments Monokai. Discussion:
  https://chat.zulip.org/#narrow/stream/431-redesign-project/topic/code.20span.20colors/near/1832283

LICENSE and AUTHORS files downloaded from:
  https://github.com/pygments/pygments/blob/f64833d9d/LICENSE
  https://github.com/pygments/pygments/blob/f64833d9d/AUTHORS

(I've included AUTHORS because LICENSE refers to it.)

Fixes: zulip#749
Related: zulip#95
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Jun 26, 2024
@chrisbobbe
content [nfc]: Name CodeBlockTextStyles's factory constructor "light"
d955039 
We're about to add a "dark", for zulip#749 / zulip#95 dark theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-design Visual and UX design
Projects
Flutter app
Status: Done
Milestone
Beta 3: Summer 2024
Development

Successfully merging a pull request may close this issue.

content: Implement Pygments Monokai, for upcoming dark theme chrisbobbe/zulip-flutter
2 participants
@gnprice @chrisbobbe