deps: Unpin intl, to follow Flutter's pinning; trim comments #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, link to the docs -- including the upstream template file itself, in case one wants to refer to any information that was in these comments specifically. Also link to our own instructions for a couple of items.
This isn't a helpful place for this information, because there's no reason one would be looking in the pubspec at a time when one needs it. We have the same information about `flutter run` and `flutter gen-l10n` in the README already, which is a better home. The part about lib/l10n/ is just inaccurate; there's no such directory in our tree. I think that may have been the home of what's now assets/l10n/, in a previous draft of the PR that introduced this.
See comment for rationale. In particular this is required for adding our tests to Flutter's "customer tests", zulip#239: flutter/tests@a047b7a
|
LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpinning
package:intlis required for adding our tests to Flutter's "customer tests", #239:flutter/tests@a047b7a
See comment added in the last commit here for background.
Also cut some unnecessary (or no-longer-necessary) verbose comments that we've had in this file, mostly left by the
flutter createtemplate.