Add browser field to package.json to ignore fs-readfile-promise #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bundlers including Browserify[1] and Parcel[2] use the browser field in package.json to ignore modules (using browser-resolve[3]) that do not work well with browsers. In our case this is the zuliprc related module, fs-readfile-promise. This commit adds a browser field with fs-readfile-promise set to false to the package.json, so that clients that are bundled with Browserify or Parcel can use zulip-js out of the box. 1: https://github.com/browserify/browserify-handbook#browser-field 2: parcel-bundler/parcel#200 3: https://github.com/defunctzombie/node-browser-resolve
|
@aero31aero I assume you'll review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bundlers including Browserify[1] and Parcel[2] use the browser field in package.json to ignore modules (using browser-resolve[3]) that do not work well with browsers.
In our case this is the zuliprc related module, fs-readfile-promise.
This commit adds a browser field with fs-readfile-promise set to false to the package.json, so that clients that are bundled with Browserify or Parcel can use zulip-js out of the box.
1: https://github.com/browserify/browserify-handbook#browser-field
2: parcel-bundler/parcel#200
3: https://github.com/defunctzombie/node-browser-resolve