WIP: Feature: Add Spoiler support #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ezio-Sarthak
added
area: message rendering
enhancement
This commit: * adds new style (LIGHTGREENBOLD, LIGHTGREENBOLD24) for spoiler header in `themes.py`. * adds markup entry in `soup2markup` for spoilers. Tests added. Co-authored-by: Sarthak Garg <grgsrthk.dev20@gmail.com>
This commit handles content metadata in `soup2markup` for spoilers. Test amended. Co-authored-by: Preet Mishra <ipreetmishra@gmail.com>
This commit adds popup to show hidden spoiler content. Tests added. Co-authored-by: Preet Mishra <ipreetmishra@gmail.com>
Tests amended. Co-authored-by: Preet Mishra <ipreetmishra@gmail.com>
This commit adds a button that would allow user to view the spoiler content, i.e., onclick of button is SpoilerView popup. Tests added. Co-authored-by: Preet Mishra <ipreetmishra@gmail.com>
Ezio-Sarthak
force-pushed
the
feature-spoiler-support
branch
from
3c2836b
to
bd66682
Compare
This commit wraps-up the PR by appending the SpoilerButton to message info view if present. Fixes zulip#688. Co-authored-by: Preet Mishra <ipreetmishra@gmail.com>
Ezio-Sarthak
force-pushed
the
feature-spoiler-support
branch
from
bd66682
to
8c5e15a
Compare
|
@Ezio-Sarthak I just gave this a try - it looks good, and is a definite improvement over just showing the content like now!
|
neiljp
added
PR awaiting update
|
Heads up @Ezio-Sarthak, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
4 tasks
neiljp
added
version parity: 3
PR completion candidate
|
As per the issue, this set of features was discussed in the topic starting at https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Spoilers!.20.23T688.20.23T1061.20.231173/near/904352. |
|
I'll be looking into this, will submit a WIP PR soon. |
neiljp
added
missing feature: user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@preetmishra Thanks for your primary work on this in a local branch, that helped me structuring this PR with separate commits and additional tests. This PR adds a basic support for spoilers in ZT.
Fixes #688.
Potential caveats
Commit flow:
Screenshots/GIFs