Fix bad rendering of new topics when topics list was open. #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zee-bit
force-pushed
the
fix-new-topic-topic-list-bug
branch
from
e1d3c9c
to
5ee3136
Compare
zulipbot
added
size: L
zee-bit
force-pushed
the
fix-new-topic-topic-list-bug
branch
from
5ee3136
to
dad59c1
Compare
zee-bit
added
area: UI
neiljp
added
PR awaiting update
zee-bit
force-pushed
the
fix-new-topic-topic-list-bug
branch
2 times, most recently
from
ccf558a
to
d47ec04
Compare
zee-bit
added
PR needs review
zee-bit
force-pushed
the
fix-new-topic-topic-list-bug
branch
from
d47ec04
to
f8e5113
Compare
This commit adds the "*" method of passing required parameters using keyword arguments to TopicButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future.
This commit adds the "*" method of passing required parameters using keyword arguments to HomeButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to TopicButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to MentionedButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future.
This commit adds the "*" method of passing required parameters using keyword arguments to StarredButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to StreamButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to UserButton. This ensures that we pass the correct parameters to our class and don't miss any, thus preventing bugs and reducing connascence between parts of the program. We also remove the default value of count from the parameters, because we are explicitly calling it with some value, and this will help avoid any potential issues in the future. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to MessageLinkButton. Tests amended.
This commit adds the "*" method of passing required parameters using keyword arguments to EditModeButton.
neiljp
force-pushed
the
fix-new-topic-topic-list-bug
branch
from
f8e5113
to
3f3c82c
Compare
|
@zee-bit Thanks for the update for the counts 👍 I just pushed a minor commit text adjustment to remove width mention (that was removed already elsewhere?) and add a missing I'm waiting for tests to pass and then will merge 🎉 |
neiljp
added
PR ready to be merged
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that made incoming new topics rendered badly when the topic list was open due to incorrect parameters being passed to
TopicButton. This PR also migratesTopicButtonto accept only named parameters so that there's no scope of bug and connascence between parts of the program is reduced.The discussion regarding this bug can be found in #zulip-terminal>New-topic topic-list bug