Define and use Stream data fixture from conftest #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-defines two dictionaries, general_stream and secret_stream as fixtures, so that they can be re-used individually in tests that demand a single stream fixture. This refactor will be particularly useful in the future for testing different behaviors of StreamInfo popup.
This commit adds the missing "rendered_description" field to stream fixtures so that they contain the full set of required fields for StreamInfo view. This will allow the fixture to be used for testing different behaviors of the StreamInfo popup.
zee-bit
force-pushed
the
streamdata-to-fixture
branch
3 times, most recently
from
a6c65d4
to
84316c3
Compare
This commit refactors test functions within TestStreamInfo to use the general_stream fixture from conftest, instead of defining custom stream dictionaries inside the test body. This will be helpful when we add typing in test_popups.py, plus we get to re-use the defined fixtures which prevents code duplication. The commit also filters out a few unused parameters in the test functions.
zee-bit
force-pushed
the
streamdata-to-fixture
branch
from
84316c3
to
2cdae51
Compare
|
Hello @zulip/server-refactoring members, this pull request was labeled with the "area: refactoring" label, so you may want to check it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR defines the
general_streamandsecret_streamdictionaries in conftest to pytest fixtures, allowing us to re-use them in tests that need stream data. The defined fixtures are currently used in tests for StreamInfo popup.Tested?
Commit flow
Interactions