Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Button for Stream Messages, towards Private Messages Sidemenu. #1243

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[WIP] Button for Stream Messages, towards Private Messages Sidemenu. #1243

wants to merge 7 commits into from

Conversation

plugyawn
Copy link
Collaborator

@plugyawn plugyawn commented Jul 5, 2022 •
edited
Loading

What does this PR do?

Towards a fix for #1197.
Adds a StreamMessage total in the top left.

WIP PR, accidentally wrote it on top of some pre-existing code -- I'll be updating the PR asap, just wanted to know if it was working properly.

Tested?

  • Manually, but there are errors.
  • Existing tests (adapted, if necessary)
  • New tests added (for any new behavior)
  • Passed linting & tests (each commit)

Commit flow

Notes & Questions

  • Need to check if the PMs indeed are not appearing in the narrow.
  • Need to fix the counter, seems to be not updating.

Interactions

Visual changes
image

@zulipbot zulipbot added the size: L [Automatic label added by zulipbot] label Jul 5, 2022
@zulipbot zulipbot added size: M [Automatic label added by zulipbot] and removed size: L [Automatic label added by zulipbot] labels Jul 5, 2022
@plugyawn plugyawn requested a review from neiljp July 5, 2022 15:44
@plugyawn plugyawn closed this Jul 5, 2022
@plugyawn plugyawn reopened this Jul 5, 2022
@zulipbot zulipbot added size: L [Automatic label added by zulipbot] and removed size: M [Automatic label added by zulipbot] labels Jul 5, 2022
@zulipbot zulipbot added size: XL [Automatic label added by zulipbot] and removed size: L [Automatic label added by zulipbot] labels Aug 6, 2022
@zulipbot
Copy link
Member

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neiljp neiljp Awaiting requested review from neiljp

Assignees
No one assigned
Labels
has conflicts size: XL [Automatic label added by zulipbot]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plugyawn @zulipbot