Add Application config menu in About section.

[zee-bit]

The about section has now an added menu Application Configuration, that lists the options that Zulip-terminal was loaded with. Here is the screenshot of the new About section:

Fixes #812

[zulipbot]

Hello @zee-bit, it seems like you have referenced #812 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #812..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

[neiljp]

@zee-bit Thanks for working on this 👍 The code change looks reasonable and works fine :)

It would be good to fix the tests - you can try running pytest like I mentioned in the issue. The errors are in the core and popups tests, and it looks like a lot, but you should see that many of these are duplicates. You may find the -x (fail after any failure) and --lf (just run recent last-failing tests) options useful.

In addition, while the commit title text is fine, if you take a look at our development notes in the README or browse our git history, you'll see that we have a different style, which it would be great if you could adapt the commit to 👍 I'm not sure why you have the commit summary text you have - we can discuss that or anything else here or in the #zulip-terminal stream if you like.

[neiljp]

Since you've added an extra parameter to this method, this has broken the tests which expect a different number of parameters.

[neiljp]

The extra parameters added here also have broken the AboutView tests, so you'll need to update these too.

[zee-bit]

I wasn't able to think of a way to access these parameters in test_popups so, I just hard-coded them. I think for testing purposes this should be okay, as we just need to check the parameters given are fine and with desired types. I also looked at other classes from the test_popup file and I found some similar cases there as well.

[neiljp]

@zee-bit Thanks for working on this 👍 I squashed your commits together to avoid an intermediate state where the tests were broken and have reworded them to match our style, as per my earlier review. I've pushed that commit as 24519ac 🎉

[zee-bit]

@neiljp Thanks for the review and those handy pytest flags, they helped a lot. As for the commit summary, I'll try to adapt myself to the recommended way asap. Looking forward to work on more issues 💯

[neiljp]

@zee-bit Thanks for the contribution 👍 We've discussed adding pytest tips to the docs previously, so I've added some to #820 at https://github.com/neiljp/zulip-terminal/tree/2020-11-03-FAQ-updates#tips-for-working-with-tests-pytest

If you have any feedback, please let us know :)

[zee-bit]

@neiljp This is a very nice addition. Although the list of commands is more than enough for testing ZT code-changes, it would be better if we could add the link to official pytest docs there too.