Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: views: Fixed Exit Popup from Stream Members view. #878

Closed
wants to merge 1 commit into from
Closed

bugfix: views: Fixed Exit Popup from Stream Members view. #878

wants to merge 1 commit into from

Conversation

zee-bit
Copy link
Member

@zee-bit zee-bit commented Jan 16, 2021

Follow-up bugfix for merged PR #T856.

@zee-bit
bugfix: views: Fixed Exit Popup from Stream Members view.
f5c90d2 
This commit fixes the bug in StreamMembersView that prevented
closing the current and super popup with super().keypress from
within StreamMembersView.

Follow-up bugfix for #T856.
@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Jan 16, 2021
@neiljp
Copy link
Collaborator

neiljp commented Jan 16, 2021

@zee-bit Thanks for the prompt update to your own PR 👍 I would have merged as-is, but note that the 'T' prefix in commit text is chat.zulip.org specific, and on GitHub there is no prefix, it is just #856.

@neiljp neiljp closed this Jan 16, 2021
@neiljp neiljp added this to the Next Release milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: XS [Automatic label added by zulipbot]
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zee-bit @neiljp @zulipbot