Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal background comes up when resizing browser #77

Open
pvitaly opened this issue Mar 1, 2013 · 6 comments
Open

Modal background comes up when resizing browser #77

pvitaly opened this issue Mar 1, 2013 · 6 comments

Comments

@pvitaly
Copy link

pvitaly commented Mar 1, 2013

Is anyone having a problem with their modal and resizing your browser? What I mean is, after I click out of my modal and the joyride is finished and then I go to resize my browser by dragging a corner, the transparent background from the modal comes up (without the actual modal window) and you have to click on the page to get rid of it.

Some info:

I have 2 joyrides on my site that are activated depending on which cookie you have. The issue seems to be with just 1 of the 2 joy rides. That joyride has only 1 item - the modal.

@mrsweaters
Copy link
Contributor

I recently fixed this issue in the Foundation Joyride version. I will back port this to standalone.

@pvitaly
Copy link
Author

pvitaly commented Mar 13, 2013

The issue is still happening in the new version. I have a tour where the modal is the first stop, and if I X out of the modal to stop the tour and resize the window, the issue happens and then the next stop pops up.

@nmall
Copy link

nmall commented Jun 12, 2013

@mrsweaters Any chance these changes can be put into place soon?

@tom-mayer
Copy link

I can also reproduce this issue. div.joyride-modal-bg display is set to "block" from "none" after resizing the browser. Any chance we might get your fix in the standalone @mrsweaters?

Thanks

@imjoeybrennan
Copy link

+1 @mrsweaters

@jakefleming
Copy link

Not sure if this is related, but there's also an issue with the modal bg not disappearing if you hit the previous button from the joyride modal back to a joyride tooltip that shouldn't have a modal. And if you have a button that's triggering joyride and the user goes through the joyride once and clicks to go through again, the modal bg is back for the whole ride.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants